From 5b7fe2b327fb715410c41c1520c2ccf8799749d8 Mon Sep 17 00:00:00 2001 From: Noel De Martin Date: Tue, 8 Jun 2021 17:54:33 +0200 Subject: [PATCH 1/4] MOBILE-3320 a11y: Add missing back button labels --- src/core/features/login/pages/credentials/credentials.html | 2 +- src/core/features/login/pages/reconnect/reconnect.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/features/login/pages/credentials/credentials.html b/src/core/features/login/pages/credentials/credentials.html index 94761a0de..73e6407e9 100644 --- a/src/core/features/login/pages/credentials/credentials.html +++ b/src/core/features/login/pages/credentials/credentials.html @@ -1,7 +1,7 @@ - +

{{ 'core.login.login' | translate }}

diff --git a/src/core/features/login/pages/reconnect/reconnect.html b/src/core/features/login/pages/reconnect/reconnect.html index d64bbe29a..96f21005a 100644 --- a/src/core/features/login/pages/reconnect/reconnect.html +++ b/src/core/features/login/pages/reconnect/reconnect.html @@ -1,7 +1,7 @@ - +

{{ 'core.login.reconnect' | translate }}

From 69d59cd2ab9b9b5fb2f2cae8c7fa83cab258b752 Mon Sep 17 00:00:00 2001 From: Noel De Martin Date: Tue, 8 Jun 2021 19:24:35 +0200 Subject: [PATCH 2/4] MOBILE-3320 a11y: Add missing labels --- .../component/addon-mod-assign-feedback-comments.html | 2 +- .../password/component/addon-mod-quiz-access-password.html | 2 +- src/addons/mod/wiki/pages/edit/edit.html | 4 ++-- src/addons/notes/components/add/add-modal.html | 2 +- src/addons/qtype/essay/component/addon-qtype-essay.html | 2 +- .../components/self-enrol-password/self-enrol-password.html | 2 +- .../login/pages/forgotten-password/forgotten-password.html | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/addons/mod/assign/feedback/comments/component/addon-mod-assign-feedback-comments.html b/src/addons/mod/assign/feedback/comments/component/addon-mod-assign-feedback-comments.html index 5032d3482..b56fbcdd8 100644 --- a/src/addons/mod/assign/feedback/comments/component/addon-mod-assign-feedback-comments.html +++ b/src/addons/mod/assign/feedback/comments/component/addon-mod-assign-feedback-comments.html @@ -24,7 +24,7 @@ - + {{ plugin.name }} - + {{ 'addon.mod_quiz.quizpassword' | translate }} diff --git a/src/addons/mod/wiki/pages/edit/edit.html b/src/addons/mod/wiki/pages/edit/edit.html index babf9f585..3d30531df 100644 --- a/src/addons/mod/wiki/pages/edit/edit.html +++ b/src/addons/mod/wiki/pages/edit/edit.html @@ -19,14 +19,14 @@
- + {{ 'addon.mod_wiki.newpagetitle' | translate }} - + {{ 'core.content' | translate }} diff --git a/src/addons/notes/components/add/add-modal.html b/src/addons/notes/components/add/add-modal.html index 843df9053..1f30665e1 100644 --- a/src/addons/notes/components/add/add-modal.html +++ b/src/addons/notes/components/add/add-modal.html @@ -19,7 +19,7 @@ - + {{ 'addon.notes.note' | translate }} diff --git a/src/addons/qtype/essay/component/addon-qtype-essay.html b/src/addons/qtype/essay/component/addon-qtype-essay.html index 820882739..40e4359b7 100644 --- a/src/addons/qtype/essay/component/addon-qtype-essay.html +++ b/src/addons/qtype/essay/component/addon-qtype-essay.html @@ -12,7 +12,7 @@ - + {{ 'core.question.answer' | translate }} diff --git a/src/core/features/courses/components/self-enrol-password/self-enrol-password.html b/src/core/features/courses/components/self-enrol-password/self-enrol-password.html index d0d755fbb..e718d5487 100644 --- a/src/core/features/courses/components/self-enrol-password/self-enrol-password.html +++ b/src/core/features/courses/components/self-enrol-password/self-enrol-password.html @@ -12,7 +12,7 @@ - + {{ 'core.courses.password' | translate }} - + {{ 'core.login.usernameoremail' | translate }} From 00dcac0b9cf3af68f235eb2183738a660fcb09eb Mon Sep 17 00:00:00 2001 From: Noel De Martin Date: Wed, 9 Jun 2021 12:16:06 +0200 Subject: [PATCH 3/4] MOBILE-3320 chart: Fix rendering null legend items --- src/core/components/chart/chart.ts | 12 ++++++++++++ src/core/components/chart/core-chart.html | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/core/components/chart/chart.ts b/src/core/components/chart/chart.ts index 5021bd313..dbff890ca 100644 --- a/src/core/components/chart/chart.ts +++ b/src/core/components/chart/chart.ts @@ -57,6 +57,7 @@ export class CoreChartComponent implements OnDestroy, OnInit, OnChanges { @ViewChild('canvas') canvas?: ElementRef; chart?: ChartWithLegend; + legendItems: ChartLegendLabelItem[] = []; /** * @inheritdoc @@ -105,6 +106,8 @@ export class CoreChartComponent implements OnDestroy, OnInit, OnChanges { }, options: { legend }, }); + + this.updateLegendItems(); } /** @@ -126,6 +129,8 @@ export class CoreChartComponent implements OnDestroy, OnInit, OnChanges { }; this.chart.data.labels = this.labels; this.chart.update(); + + this.updateLegendItems(); } /** @@ -179,6 +184,13 @@ export class CoreChartComponent implements OnDestroy, OnInit, OnChanges { } } + /** + * Recompute legendItems property. + */ + protected updateLegendItems(): void { + this.legendItems = (this.chart?.legend?.legendItems ?? []).filter(item => !!item); + } + } // For some reason the legend property isn't defined in TS, define it ourselves. diff --git a/src/core/components/chart/core-chart.html b/src/core/components/chart/core-chart.html index c0f03eb55..f8b0b20f4 100644 --- a/src/core/components/chart/core-chart.html +++ b/src/core/components/chart/core-chart.html @@ -1,7 +1,7 @@ - + {{data.text}} From 61a2ada64d030dcb34300be9086a479a84d5fde4 Mon Sep 17 00:00:00 2001 From: Noel De Martin Date: Wed, 9 Jun 2021 12:25:57 +0200 Subject: [PATCH 4/4] MOBILE-3320 e2e: Schedule tests to run once a day --- .github/workflows/e2e.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 4285a04aa..77b5a6289 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -1,6 +1,8 @@ name: E2E -on: [push, pull_request] +on: + schedule: + - cron: '0 0 * * *' # every day at midnight jobs: e2e: