diff --git a/src/addon/files/pages/list/list.html b/src/addon/files/pages/list/list.html index 791a6d6db..9bb3ee955 100644 --- a/src/addon/files/pages/list/list.html +++ b/src/addon/files/pages/list/list.html @@ -36,7 +36,7 @@ - + diff --git a/src/addon/messages/pages/discussion/discussion.html b/src/addon/messages/pages/discussion/discussion.html index 1c7b2e325..89bd5a6be 100644 --- a/src/addon/messages/pages/discussion/discussion.html +++ b/src/addon/messages/pages/discussion/discussion.html @@ -12,7 +12,7 @@ - + diff --git a/src/addon/mod/assign/components/submission/addon-mod-assign-submission.html b/src/addon/mod/assign/components/submission/addon-mod-assign-submission.html index ba7f9c590..f8d03552a 100644 --- a/src/addon/mod/assign/components/submission/addon-mod-assign-submission.html +++ b/src/addon/mod/assign/components/submission/addon-mod-assign-submission.html @@ -112,15 +112,15 @@

{{ 'addon.mod_assign.userswhoneedtosubmit' | translate: {$a: ''} }}

- +

{{ user.fullname }}

-

+ {{ 'addon.mod_assign.hiddenuser' | translate }} -

+
diff --git a/src/addon/mod/assign/feedback/comments/component/addon-mod-assign-feedback-comments.html b/src/addon/mod/assign/feedback/comments/component/addon-mod-assign-feedback-comments.html index 62f3857f9..cfb780447 100644 --- a/src/addon/mod/assign/feedback/comments/component/addon-mod-assign-feedback-comments.html +++ b/src/addon/mod/assign/feedback/comments/component/addon-mod-assign-feedback-comments.html @@ -5,7 +5,7 @@

-
+
diff --git a/src/addon/mod/book/components/toc-popover/addon-mod-assign-submission-toc-popover.html b/src/addon/mod/book/components/toc-popover/addon-mod-assign-submission-toc-popover.html index ed35905b6..6d3dca6f0 100644 --- a/src/addon/mod/book/components/toc-popover/addon-mod-assign-submission-toc-popover.html +++ b/src/addon/mod/book/components/toc-popover/addon-mod-assign-submission-toc-popover.html @@ -1,5 +1,5 @@ -

{{chapter.title}}

+

{{chapter.title}}

diff --git a/src/addon/mod/chat/pages/chat/chat.html b/src/addon/mod/chat/pages/chat/chat.html index fbdf3bce1..c440dce08 100644 --- a/src/addon/mod/chat/pages/chat/chat.html +++ b/src/addon/mod/chat/pages/chat/chat.html @@ -8,7 +8,7 @@ - +
diff --git a/src/addon/mod/data/components/index/addon-mod-data-index.html b/src/addon/mod/data/components/index/addon-mod-data-index.html index 3d3d4e3f2..c195f2b41 100644 --- a/src/addon/mod/data/components/index/addon-mod-data-index.html +++ b/src/addon/mod/data/components/index/addon-mod-data-index.html @@ -92,7 +92,7 @@ - + diff --git a/src/addon/mod/data/pages/search/search.html b/src/addon/mod/data/pages/search/search.html index fe3f63426..fcc6e1830 100644 --- a/src/addon/mod/data/pages/search/search.html +++ b/src/addon/mod/data/pages/search/search.html @@ -47,9 +47,11 @@
- +
+ +
diff --git a/src/addon/mod/feedback/components/index/index.ts b/src/addon/mod/feedback/components/index/index.ts index cc0e922d9..74ac6e14d 100644 --- a/src/addon/mod/feedback/components/index/index.ts +++ b/src/addon/mod/feedback/components/index/index.ts @@ -423,9 +423,10 @@ export class AddonModFeedbackIndexComponent extends CoreCourseModuleMainActivity this.warning = ''; if (analysis.warnings.length) { - this.warning = analysis.warnings.find((warning) => { + const warning = analysis.warnings.find((warning) => { return warning.warningcode == 'insufficientresponsesforthisgroup'; }); + this.warning = warning && warning.message; } } }); diff --git a/src/addon/mod/feedback/providers/helper.ts b/src/addon/mod/feedback/providers/helper.ts index cbd1ea4d5..87d75b0bb 100644 --- a/src/addon/mod/feedback/providers/helper.ts +++ b/src/addon/mod/feedback/providers/helper.ts @@ -13,7 +13,7 @@ // limitations under the License. import { Injectable } from '@angular/core'; -import { NavController } from 'ionic-angular'; +import { NavController, ViewController } from 'ionic-angular'; import { AddonModFeedbackProvider } from './feedback'; import { CoreUserProvider } from '@core/user/providers/user'; import { CoreTextUtilsProvider } from '@providers/utils/text'; @@ -35,17 +35,17 @@ export class AddonModFeedbackHelperProvider { } /** - * Check if the page we are going to open is in the history and returns the number of pages in the stack to go back. + * Check if the page we are going to open is in the history and returns the view controller in the stack to go back. * * @param {string} pageName Name of the page we want to navigate. * @param {number} instance Activity instance Id. I.e FeedbackId. * @param {string} paramName Param name where to find the instance number. * @param {string} prefix Prefix to check if we are out of the activity context. * @param {NavController} navCtrl Nav Controller of the view. - * @return {number} Returns the number of times the history needs to go back to find the specified page. + * @return {ViewController} Returns view controller found or null. */ - protected getActivityHistoryBackCounter(pageName: string, instance: number, paramName: string, prefix: string, - navCtrl: NavController): number { + protected getPageView(pageName: string, instance: number, paramName: string, prefix: string, + navCtrl: NavController): ViewController { let historyInstance, params, view = navCtrl.getActive(); @@ -65,13 +65,13 @@ export class AddonModFeedbackHelperProvider { // Page found. if (view.name == pageName) { - return view.index; + return view; } view = navCtrl.getPrevious(view); } - return 0; + return null; } /** @@ -223,26 +223,24 @@ export class AddonModFeedbackHelperProvider { * @return {Promise} Resolved when navigation animation is done. */ openFeature(feature: string, navCtrl: NavController, module: any, courseId: number, group: number = 0): Promise { - const pageName = feature && feature != 'analysis' ? 'AddonModFeedback' + feature + 'Page' : 'AddonModFeedbackIndexPage'; - let backTimes = 0; - - const stateParams = { - module: module, - moduleId: module.id, - courseId: courseId, - feedbackId: module.instance, - group: group - }; + const pageName = feature && feature != 'analysis' ? 'AddonModFeedback' + feature + 'Page' : 'AddonModFeedbackIndexPage', + stateParams = { + module: module, + moduleId: module.id, + courseId: courseId, + feedbackId: module.instance, + group: group + }; // Only check history if navigating through tabs. if (pageName == 'AddonModFeedbackIndexPage') { stateParams['tab'] = feature == 'analysis' ? 'analysis' : 'overview'; - backTimes = this.getActivityHistoryBackCounter(pageName, module.instance, 'feedbackId', 'AddonModFeedback', navCtrl); - } + const view = this.getPageView(pageName, module.instance, 'feedbackId', 'AddonModFeedback', navCtrl); - if (backTimes > 0) { - // Go back X times until the the page we want to reach. - return navCtrl.remove(navCtrl.getActive().index, backTimes); + if (view) { + // Go back to the found page. + return navCtrl.popTo(view); + } } // Not found, open new state. diff --git a/src/addon/mod/forum/components/index/addon-mod-forum-index.html b/src/addon/mod/forum/components/index/addon-mod-forum-index.html index ddbebcadf..8d88b2378 100644 --- a/src/addon/mod/forum/components/index/addon-mod-forum-index.html +++ b/src/addon/mod/forum/components/index/addon-mod-forum-index.html @@ -32,12 +32,12 @@

- {{ 'core.notsent' | translate }} + {{ 'core.notsent' | translate }} {{discussion.userfullname}}

- + {{ discussion.groupname }}

@@ -50,9 +50,9 @@

- + {{discussion.created | coreDateDayOrTime}} -

{{ 'addon.mod_forum.unreadpostsnumber' | translate:{ '$a' : discussion.numunread} }}
+
{{ 'addon.mod_forum.unreadpostsnumber' | translate:{ '$a' : discussion.numunread} }}
{{discussion.userfullname}}

@@ -93,7 +93,7 @@ - + diff --git a/src/addon/mod/forum/components/index/index.ts b/src/addon/mod/forum/components/index/index.ts index 72993f242..8ab76ab1f 100644 --- a/src/addon/mod/forum/components/index/index.ts +++ b/src/addon/mod/forum/components/index/index.ts @@ -88,6 +88,12 @@ export class AddonModForumIndexComponent extends CoreCourseModuleMainActivityCom this.viewDiscObserver = this.eventsProvider.on(AddonModForumProvider.VIEW_DISCUSSION_EVENT, (data) => { if (this.forum && this.forum.id == data.forumId) { this.selectedDiscussion = this.splitviewCtrl.isOn() ? data.discussion : 0; + + // Invalidate discussion list if it was not read. + const discussion = this.discussions.find((disc) => disc.discussion == data.discussion); + if (discussion && discussion.numunread > 0) { + this.forumProvider.invalidateDiscussionsList(this.forum.id); + } } }, this.sitesProvider.getCurrentSiteId()); @@ -406,7 +412,7 @@ export class AddonModForumIndexComponent extends CoreCourseModuleMainActivityCom forumId: this.forum.id, discussionId: discussion.discussion, trackPosts: this.trackPosts, - locked: discussion.locked && !discussion.canreply + locked: discussion.locked }; this.splitviewCtrl.push('AddonModForumDiscussionPage', params); } diff --git a/src/addon/mod/forum/components/post/addon-mod-forum-post.html b/src/addon/mod/forum/components/post/addon-mod-forum-post.html index b5d7c22eb..17a9779ad 100644 --- a/src/addon/mod/forum/components/post/addon-mod-forum-post.html +++ b/src/addon/mod/forum/components/post/addon-mod-forum-post.html @@ -1,18 +1,20 @@ - - - - -

-

- {{ 'core.notsent' | translate }} - - {{post.modified | coreDateDayOrTime}} -

{{ 'addon.mod_forum.unread' | translate }}
- - {{post.userfullname}} -

-
- + + + + + +

+

+ {{ 'core.notsent' | translate }} + + {{post.modified | coreDateDayOrTime}} +

{{ 'addon.mod_forum.unread' | translate }}
+ + {{post.userfullname}} +

+
+
+
@@ -21,12 +23,12 @@
- + - + diff --git a/src/addon/mod/forum/pages/discussion/discussion.html b/src/addon/mod/forum/pages/discussion/discussion.html index dd59860cf..3d0048019 100644 --- a/src/addon/mod/forum/pages/discussion/discussion.html +++ b/src/addon/mod/forum/pages/discussion/discussion.html @@ -30,7 +30,7 @@ {{ 'addon.mod_forum.discussionlocked' | translate }} - + @@ -51,7 +51,7 @@ -
+
diff --git a/src/addon/mod/forum/pages/discussion/discussion.scss b/src/addon/mod/forum/pages/discussion/discussion.scss new file mode 100644 index 000000000..b4151f311 --- /dev/null +++ b/src/addon/mod/forum/pages/discussion/discussion.scss @@ -0,0 +1,9 @@ +ion-app.app-root page-addon-mod-forum-discussion { + .card.highlight .card-header .item { + background-color: $gray-lighter; + } + + .addon-forum-reply-button .label { + margin: 0; + } +} \ No newline at end of file diff --git a/src/addon/mod/glossary/components/index/addon-mod-glossary-index.html b/src/addon/mod/glossary/components/index/addon-mod-glossary-index.html index adf3b4689..4ad1add14 100644 --- a/src/addon/mod/glossary/components/index/addon-mod-glossary-index.html +++ b/src/addon/mod/glossary/components/index/addon-mod-glossary-index.html @@ -61,7 +61,7 @@ - + diff --git a/src/addon/mod/imscp/components/toc-popover/addon-mod-imscp-toc-popover.html b/src/addon/mod/imscp/components/toc-popover/addon-mod-imscp-toc-popover.html index 4c1c9b21b..6bda8d594 100644 --- a/src/addon/mod/imscp/components/toc-popover/addon-mod-imscp-toc-popover.html +++ b/src/addon/mod/imscp/components/toc-popover/addon-mod-imscp-toc-popover.html @@ -1,5 +1,5 @@ - {{item.title}} + {{item.title}} diff --git a/src/addon/mod/lesson/pages/player/player.html b/src/addon/mod/lesson/pages/player/player.html index 6bb4f6a75..a6a2c73c6 100644 --- a/src/addon/mod/lesson/pages/player/player.html +++ b/src/addon/mod/lesson/pages/player/player.html @@ -50,7 +50,7 @@ - + diff --git a/src/addon/mod/lesson/pages/player/player.scss b/src/addon/mod/lesson/pages/player/player.scss index f492ff4b3..9e0535938 100644 --- a/src/addon/mod/lesson/pages/player/player.scss +++ b/src/addon/mod/lesson/pages/player/player.scss @@ -7,11 +7,6 @@ ion-app.app-root page-addon-mod-lesson-player { ion-input[padding-left] input[padding-left] { // Applying padding-left to the ion-input applies it twice since it's replicated in the inner input. - padding-left: 0; - } - - ion-input[padding-start] input[padding-start] { - // Applying padding-start to the ion-input applies it twice since it's replicated in the inner input. @include padding(null, null, null, 0); } diff --git a/src/addon/mod/quiz/pages/review/review.html b/src/addon/mod/quiz/pages/review/review.html index 1d6ffb483..49670516f 100644 --- a/src/addon/mod/quiz/pages/review/review.html +++ b/src/addon/mod/quiz/pages/review/review.html @@ -88,12 +88,12 @@ - + - + diff --git a/src/addon/mod/wiki/components/index/addon-mod-wiki-index.html b/src/addon/mod/wiki/components/index/addon-mod-wiki-index.html index 2747bb87e..ffa86beb8 100644 --- a/src/addon/mod/wiki/components/index/addon-mod-wiki-index.html +++ b/src/addon/mod/wiki/components/index/addon-mod-wiki-index.html @@ -73,7 +73,7 @@ - + diff --git a/src/addon/mod/wiki/components/index/index.ts b/src/addon/mod/wiki/components/index/index.ts index bf0116676..b030bbb16 100644 --- a/src/addon/mod/wiki/components/index/index.ts +++ b/src/addon/mod/wiki/components/index/index.ts @@ -84,7 +84,7 @@ export class AddonModWikiIndexComponent extends CoreCourseModuleMainActivityComp protected userProvider: CoreUserProvider, private popoverCtrl: PopoverController) { super(injector, content); - this.pageStr = this.translate.instant('addon.mod_wiki.page'); + this.pageStr = this.translate.instant('addon.mod_wiki.wikipage'); } /** diff --git a/src/addon/mod/wiki/lang/en.json b/src/addon/mod/wiki/lang/en.json index d8b4dcca2..e8d9a0d78 100644 --- a/src/addon/mod/wiki/lang/en.json +++ b/src/addon/mod/wiki/lang/en.json @@ -10,7 +10,6 @@ "newpagetitle": "New page title", "nocontent": "There is no content for this page", "notingroup": "Not in group", - "page": "Page", "pageexists": "This page already exists.", "pagename": "Page name", "subwiki": "Sub-wiki", diff --git a/src/addon/mod/workshop/components/index/addon-mod-workshop-index.html b/src/addon/mod/workshop/components/index/addon-mod-workshop-index.html index f1513402d..5ac411c4f 100644 --- a/src/addon/mod/workshop/components/index/addon-mod-workshop-index.html +++ b/src/addon/mod/workshop/components/index/addon-mod-workshop-index.html @@ -119,10 +119,13 @@ - +

{{ 'addon.mod_workshop.assignedassessments' | translate }}

+ +

{{ 'addon.mod_workshop.assignedassessmentsnone' | translate }}

+
@@ -130,7 +133,7 @@ - +

{{ 'addon.mod_workshop.submissionsreport' | translate }}

diff --git a/src/addon/mod/workshop/lang/en.json b/src/addon/mod/workshop/lang/en.json index d63f0d836..4a2056785 100644 --- a/src/addon/mod/workshop/lang/en.json +++ b/src/addon/mod/workshop/lang/en.json @@ -9,6 +9,7 @@ "assessmentstrategynotsupported": "Assessment strategy {{$a}} not supported", "assessmentweight": "Assessment weight", "assignedassessments": "Assigned submissions to assess", + "assignedassessmentsnone": "You have no assigned submission to assess", "conclusion": "Conclusion", "createsubmission": "Start preparing your submission", "deletesubmission": "Delete submission", diff --git a/src/addon/notifications/pages/list/list.html b/src/addon/notifications/pages/list/list.html index b08d112f3..c75a3d715 100644 --- a/src/addon/notifications/pages/list/list.html +++ b/src/addon/notifications/pages/list/list.html @@ -20,7 +20,7 @@

{{notification.userfromfullname}}

-
+

{{notification.timecreated | coreDateDayOrTime}}

diff --git a/src/addon/qtype/calculated/component/addon-qtype-calculated.html b/src/addon/qtype/calculated/component/addon-qtype-calculated.html index ab11e293c..db25e4f4b 100644 --- a/src/addon/qtype/calculated/component/addon-qtype-calculated.html +++ b/src/addon/qtype/calculated/component/addon-qtype-calculated.html @@ -18,7 +18,7 @@ - + diff --git a/src/addon/qtype/shortanswer/component/addon-qtype-shortanswer.html b/src/addon/qtype/shortanswer/component/addon-qtype-shortanswer.html index bdf6f49ab..550e65863 100644 --- a/src/addon/qtype/shortanswer/component/addon-qtype-shortanswer.html +++ b/src/addon/qtype/shortanswer/component/addon-qtype-shortanswer.html @@ -2,6 +2,6 @@

- + diff --git a/src/app/app.ios.scss b/src/app/app.ios.scss index 8684dbd18..c6d73a607 100644 --- a/src/app/app.ios.scss +++ b/src/app/app.ios.scss @@ -59,71 +59,6 @@ ion-app.app-root.ios { height: 100%; } - - // Highlights inside the input element. - @if ($core-text-input-ios-show-highlight) { - .card-ios, .list-ios { - // In order to get a 2px border we need to add an inset - // box-shadow 1px (this is to avoid the div resizing) - - // The last item in a list has a border on the item, not the - // inner item, so add it to the item itself - .item-input.item-input-has-focus:last-child, - .item-input.input-has-focus:last-child { - @include ios-input-highlight($text-input-ios-highlight-color); - - .item-inner ion-input { - box-shadow: none; - } - } - - // Show the focus highlight when the input has focus - .item-input.ng-valid.item-input-has-value:not(.input-has-focus):not(.item-input-has-focus):last-child, - .item-input.ng-valid.input-has-value:not(.input-has-focus):not(.item-input-has-focus):last-child { - @include ios-input-highlight($text-input-ios-highlight-color-valid); - - .item-inner ion-input { - box-shadow: none; - } - } - - .item-input.ng-invalid.ng-touched:not(.input-has-focus):not(.item-input-has-focus):last-child { - @include ios-input-highlight($text-input-ios-highlight-color-invalid); - - .item-inner ion-input { - box-shadow: none; - } - } - } - - .item-ios.item-input { - .item-inner { - border: 0; - } - - &.item-block .item-inner ion-input { - border-bottom: $hairlines-width solid $list-border-color; - } - - // TODO remove all uses of input-has-focus in v4 - &.item-input-has-focus .item-inner ion-input, - &.input-has-focus .item-inner ion-input { - @include ios-input-highlight($text-input-ios-highlight-color); - } - - // Show the valid highlight when it has the .ng-valid class and a value - &.ng-valid.item-input-has-value:not(.input-has-focus):not(.item-input-has-focus) .item-inner ion-input, - &.ng-valid.input-has-value:not(.input-has-focus):not(.item-input-has-focus) .item-inner ion-input { - @include ios-input-highlight($text-input-ios-highlight-color-valid); - } - - // Show the invalid highlight when it has the invalid class and has been touched - &.ng-invalid.ng-touched:not(.input-has-focus):not(.item-input-has-focus) .item-inner ion-input { - @include ios-input-highlight($text-input-ios-highlight-color-invalid); - } - } - } - // Different levels of padding. @for $i from 0 through 15 { .core-padding-#{$i} { @@ -138,4 +73,22 @@ ion-app.app-root.ios { .card-ios.with-borders .item-ios:last-child .item-inner { border-bottom: 0; } + + + .radio-ios .radio-icon { + @include position(0, null, null, 0); + @include margin(0); + @include border-radius($radio-md-icon-border-radius); + + position: relative; + display: block; + + width: $checkbox-ios-icon-size; + height: $checkbox-ios-icon-size; + + border-width: $checkbox-ios-icon-border-width; + border-style: $checkbox-ios-icon-border-style; + border-color: $checkbox-ios-icon-border-color-off; + background-color: $checkbox-ios-background-color-off; + } } \ No newline at end of file diff --git a/src/app/app.md.scss b/src/app/app.md.scss index c183e0c3c..de8eefcf1 100644 --- a/src/app/app.md.scss +++ b/src/app/app.md.scss @@ -41,71 +41,6 @@ ion-app.app-root.md { height: calc(100% - #{($navbar-md-height)}); } - // Highlights inside the input element. - @if ($core-text-input-md-show-highlight) { - .card-md, .list-md { - // In order to get a 2px border we need to add an inset - // box-shadow 1px (this is to avoid the div resizing) - - // The last item in a list has a border on the item, not the - // inner item, so add it to the item itself - .item-input.item-input-has-focus:last-child, - .item-input.input-has-focus:last-child { - @include md-input-highlight($text-input-md-highlight-color); - - .item-inner ion-input { - box-shadow: none; - } - } - - .item-input.ng-valid.item-input-has-value:not(.input-has-focus):not(.item-input-has-focus):last-child, - .item-input.ng-valid.input-has-value:not(.input-has-focus):not(.item-input-has-focus):last-child { - @include md-input-highlight($text-input-md-highlight-color-valid); - - .item-inner ion-input { - box-shadow: none; - } - } - - .item-input.ng-invalid.ng-touched:not(.input-has-focus):not(.item-input-has-focus):last-child { - @include md-input-highlight($text-input-md-highlight-color-invalid); - - .item-inner ion-input { - box-shadow: none; - } - } - } - - .item-md.item-input { - .item-inner { - border: 0; - } - - &.item-block .item-inner ion-input { - border-bottom: 1px solid $list-border-color; - } - - // TODO remove all uses of input-has-focus in v4 - &.item-input-has-focus .item-inner ion-input, - &.input-has-focus .item-inner ion-input { - @include md-input-highlight($text-input-md-highlight-color); - } - - // Show the valid highlight when it has the .ng-valid class and a value - // TODO remove all uses of input-has-focus in v4 - // TODO remove all uses of input-has-value in v4 - &.ng-valid.item-input-has-value:not(.input-has-focus):not(.item-input-has-focus) .item-inner ion-input, - &.ng-valid.input-has-value:not(.input-has-focus):not(.item-input-has-focus) .item-inner ion-input { - @include md-input-highlight($text-input-md-highlight-color-valid); - } - - // Show the invalid highlight when it has the invalid class and has been touched - &.ng-invalid.ng-touched:not(.input-has-focus):not(.item-input-has-focus) .item-inner ion-input { - @include md-input-highlight($text-input-md-highlight-color-invalid); - } - } - } - // Different levels of padding. @for $i from 0 through 15 { .core-padding-#{$i} { diff --git a/src/app/app.scss b/src/app/app.scss index 59e4bfb88..3a4cf162f 100644 --- a/src/app/app.scss +++ b/src/app/app.scss @@ -374,6 +374,13 @@ ion-app.app-root { @include core-headings(); } + .item core-format-text, + core-format-text { + p { + margin-bottom: 1rem; + } + } + // Images in ion-card have width 100% and display block. Remove that when the image is in core-format-text. ion-card core-format-text img { width: min-content; @@ -396,6 +403,12 @@ ion-app.app-root { } } + .item .item-button[icon-only] { + height: 2.8em; + font-size: 1.6rem; + padding: 0 3px; + } + // Ionic fix. Button can occupy all page if not. ion-select { position: relative; @@ -411,10 +424,19 @@ ion-app.app-root { } } - :not(.item) > * > * > ion-select, + ion-select { + color: $core-select-placeholder-color; + align-self: start; + + .select-icon .select-icon-inner { + color: $core-select-placeholder-color; + } + } + + ion-select.core-button-select, .core-button-select { background-color: white; - color: $core-color; + color: $core-select-placeholder-color; white-space: normal; align-self: start; max-width: none; @@ -446,7 +468,7 @@ ion-app.app-root { } .select-icon .select-icon-inner { - color: $core-color; + color: $core-select-placeholder-color; } ion-icon:last-child { @@ -919,8 +941,10 @@ ion-app.app-root { } body.keyboard-is-open { - .scroll-content, .fixed-content { + ion-content:not(.has-footer) { + > .scroll-content, > .fixed-content { margin-bottom: 0 !important; + } } core-ion-tabs .tabbar { diff --git a/src/components/tabs/tabs.scss b/src/components/tabs/tabs.scss index 92429699d..b39c0f89e 100644 --- a/src/components/tabs/tabs.scss +++ b/src/components/tabs/tabs.scss @@ -26,6 +26,7 @@ ion-app.app-root .core-tabs-bar { word-wrap: break-word; display: block; width: 100%; + line-height: 1.2em; } &[aria-selected=true] { diff --git a/src/components/timer/core-timer.html b/src/components/timer/core-timer.html index 31262562e..03c48900c 100644 --- a/src/components/timer/core-timer.html +++ b/src/components/timer/core-timer.html @@ -1,4 +1,4 @@ - + {{ timeLeft | coreSecondsToHMS }} diff --git a/src/core/courses/components/overview-events/core-courses-overview-events.html b/src/core/courses/components/overview-events/core-courses-overview-events.html index ff5aed5ec..3e010a2a5 100644 --- a/src/core/courses/components/overview-events/core-courses-overview-events.html +++ b/src/core/courses/components/overview-events/core-courses-overview-events.html @@ -1,11 +1,11 @@ - +

{{event.timesort * 1000 | coreFormatDate:"dfmediumdate" }}

{{event.action.itemcount}}
diff --git a/src/core/courses/pages/my-overview/my-overview.html b/src/core/courses/pages/my-overview/my-overview.html index 095ac7eff..4055e823b 100644 --- a/src/core/courses/pages/my-overview/my-overview.html +++ b/src/core/courses/pages/my-overview/my-overview.html @@ -37,7 +37,7 @@
- + {{ 'core.courses.inprogress' | translate }} {{ 'core.courses.future' | translate }} {{ 'core.courses.past' | translate }} @@ -82,7 +82,7 @@
- + {{ 'core.courses.sortbydates' | translate }} {{ 'core.courses.sortbycourses' | translate }} diff --git a/src/core/emulator/pages/capture-media/capture-media.html b/src/core/emulator/pages/capture-media/capture-media.html index 8ea643e22..5e2fd78ec 100644 --- a/src/core/emulator/pages/capture-media/capture-media.html +++ b/src/core/emulator/pages/capture-media/capture-media.html @@ -11,7 +11,7 @@ - +
@@ -47,7 +47,7 @@ - + diff --git a/src/core/login/pages/site/site.html b/src/core/login/pages/site/site.html index 6632e4278..737e6ef89 100644 --- a/src/core/login/pages/site/site.html +++ b/src/core/login/pages/site/site.html @@ -14,7 +14,7 @@
-
+

{{ 'core.login.newsitedescription' | translate }}

diff --git a/src/core/login/pages/sites/sites.html b/src/core/login/pages/sites/sites.html index ffe217791..b1d283c18 100644 --- a/src/core/login/pages/sites/sites.html +++ b/src/core/login/pages/sites/sites.html @@ -24,7 +24,7 @@ - + diff --git a/src/core/login/pages/sites/sites.scss b/src/core/login/pages/sites/sites.scss index 04cca753b..ba18de255 100644 --- a/src/core/login/pages/sites/sites.scss +++ b/src/core/login/pages/sites/sites.scss @@ -1,5 +1,5 @@ ion-app.app-root page-core-login-sites { - .item-button[icon-only] ion-icon { - font-size: 2.3em; + .item-ios .item-button[icon-only] ion-icon { + font-size: 2.1em; } } diff --git a/src/core/mainmenu/pages/menu/menu.scss b/src/core/mainmenu/pages/menu/menu.scss index ae7a4fcbc..2fa0db196 100644 --- a/src/core/mainmenu/pages/menu/menu.scss +++ b/src/core/mainmenu/pages/menu/menu.scss @@ -6,11 +6,15 @@ ion-app.app-root page-core-mainmenu { .ion-fa-graduation-cap { @extend .fa-graduation-cap; @extend .fa; + font-size: 21px; + height: 21px; } .ion-ios-fa-graduation-cap-outline { color: transparent; -webkit-text-stroke-width: 0.8px; -webkit-text-stroke-color: $tabs-tab-color-inactive; + font-size: 23px; + height: 23px; } } diff --git a/src/theme/variables.scss b/src/theme/variables.scss index 10e70f4b2..2505ef59d 100644 --- a/src/theme/variables.scss +++ b/src/theme/variables.scss @@ -135,13 +135,13 @@ $core-login-box-background-border: $gray !default; $core-login-box-text-color: $text-color !default; $core-login-button-outline: false !default; $core-login-loading-color: false !default; +$core-select-placeholder-color: $core-color; // App iOS Variables // -------------------------------------------------- // iOS only Sass variables can go here $text-input-ios-show-focus-highlight: false; -$core-text-input-ios-show-highlight: false; $item-ios-avatar-size: 54px; $loading-ios-spinner-color: $core-loading-spinner-color; $spinner-ios-ios-color: $core-spinner-color; @@ -149,6 +149,7 @@ $tabs-ios-tab-color-inactive: $tabs-tab-color-inactive; $button-ios-outline-background-color: $core-button-outline-background-color; $toolbar-ios-height: 44px + 8; // Avoid toolbar with different heights. $checkbox-ios-icon-border-radius: 0px !default; +$select-ios-placeholder-color: $core-select-placeholder-color; $radio-ios-disabled-opacity: .5 !default; $checkbox-ios-disabled-opacity: .5 !default; $toggle-ios-disabled-opacity: .5 !default; @@ -157,8 +158,7 @@ $toggle-ios-disabled-opacity: .5 !default; // -------------------------------------------------- // Material Design only Sass variables can go here -$text-input-md-show-focus-highlight: false; -$core-text-input-md-show-highlight: true; +$text-input-md-show-focus-highlight: true; $item-md-detail-push-show: true; $item-md-avatar-size: 54px; $loading-md-spinner-color: $core-loading-spinner-color; @@ -166,6 +166,8 @@ $spinner-md-crescent-color: $core-spinner-color; $tabs-md-tab-color-inactive: $tabs-tab-color-inactive; $button-md-outline-background-color: $core-button-outline-background-color; $font-family-md-base: "Roboto", "Noto Sans", "Helvetica Neue", sans-serif !default; +$select-md-placeholder-color: $core-select-placeholder-color; +$label-md-text-color: $text-color !default; $radio-md-disabled-opacity: .5 !default; $checkbox-md-disabled-opacity: .5 !default; $toggle-md-disabled-opacity: .5 !default; @@ -181,6 +183,8 @@ $loading-wp-spinner-color: $core-loading-spinner-color; $spinner-wp-circles-color: $core-spinner-color; $tabs-wp-tab-color-inactive: $tabs-tab-color-inactive; $button-wp-outline-background-color: $core-button-outline-background-color; +$select-wp-placeholder-color: $core-select-placeholder-color; +$label-wp-text-color: $text-color !default; $radio-wp-disabled-opacity: .5 !default; $checkbox-wp-disabled-opacity: .5 !default; $toggle-wp-disabled-opacity: .5 !default;