EVOgeek/Vmeda.Online
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MOBILE-3814 chore: Use WaitToBeInDom on OnAppear directive

Browse Source
This commit is contained in:
Pau Ferrer Ocaña 2022-03-14 23:10:05 +01:00
parent 23cfb29de0
commit 0d01449393
2 changed files with 7 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/core/directives/collapsible-header.ts
View File

@ -199,9 +199,6 @@ export class CoreCollapsibleHeaderDirective implements OnInit, OnChanges, OnDest
}; };
this.subscriptions.push(outlet.activateEvents.subscribe(onOutletUpdated)); this.subscriptions.push(outlet.activateEvents.subscribe(onOutletUpdated));
this.subscriptions.push(outlet.activateEvents.subscribe(onOutletUpdated));
onOutletUpdated();
onOutletUpdated(); onOutletUpdated();

19
src/core/directives/on-appear.ts
View File

@ -14,6 +14,7 @@
import { Directive, ElementRef, EventEmitter, OnDestroy, OnInit, Output } from '@angular/core'; import { Directive, ElementRef, EventEmitter, OnDestroy, OnInit, Output } from '@angular/core';
import { CoreDomUtils } from '@services/utils/dom'; import { CoreDomUtils } from '@services/utils/dom';
import { CoreSingleTimeEventObserver } from '@singletons/events';
/** /**
* Directive to listen when an element becomes visible. * Directive to listen when an element becomes visible.
@ -26,7 +27,7 @@ export class CoreOnAppearDirective implements OnInit, OnDestroy {
@Output() onAppear = new EventEmitter(); @Output() onAppear = new EventEmitter();
private element: HTMLElement; private element: HTMLElement;
private interval?: number; protected domListener?: CoreSingleTimeEventObserver;
constructor(element: ElementRef) { constructor(element: ElementRef) {
this.element = element.nativeElement; this.element = element.nativeElement;
@ -35,24 +36,18 @@ export class CoreOnAppearDirective implements OnInit, OnDestroy {
/** /**
* @inheritdoc * @inheritdoc
*/ */
ngOnInit(): void { async ngOnInit(): Promise<void> {
this.interval = window.setInterval(() => { this.domListener = CoreDomUtils.waitToBeInDOM(this.element);
if (!CoreDomUtils.isElementVisible(this.element)) { await this.domListener.promise;
return;
}
this.onAppear.emit(); this.onAppear.emit();
window.clearInterval(this.interval);
delete this.interval;
}, 50);
} }
/** /**
* @inheritdoc * @inheritdoc
*/ */
ngOnDestroy(): void { ngOnDestroy(): void {
this.interval && window.clearInterval(this.interval); this.domListener?.off();
} }
} }