MOBILE-2253 core: Remove PWA files since they aren't used

src/app/app.component.ts

@@ -25,6 +25,8 @@ import { CoreLoginHelperProvider } from '../core/login/providers/helper';
 })
 export class MyApp implements AfterViewInit {
     @ViewChild(Nav) navCtrl;
+    // Use the page name (string) because the page is lazy loaded (Ionic feature). That way we can load pages without
+    // having to import them. The downside is that each page needs to implement a ngModule.
     rootPage:any = 'CoreLoginInitPage';
     protected logger;
     protected lastUrls = {};

src/core/emulator/classes/sqlitedb.ts

@@ -46,7 +46,7 @@ export class SQLiteDBMock extends SQLiteDB {
      */
     emptyDatabase() : Promise<any> {
         return new Promise((resolve, reject) => {
-            this.db.transaction(tx => {
+            this.db.transaction((tx) => {
                 // Query all tables from sqlite_master that we have created and can modify.
                 let args = [],
                     query = `SELECT * FROM sqlite_master

src/core/emulator/providers/file.ts

@@ -63,11 +63,16 @@ export class FileMock extends File {
     }
 
     /**
-     * @hidden
+     * Copy a file or directory.
+     *
+     * @param {Entry} srce The Entry to copy.
+     * @param {DirectoryEntry} destDir The directory where to put the copy.
+     * @param {string} newName New name of the file/dir.
+     * @returns {Promise<Entry>} Returns a Promise that resolves to the new Entry object or rejects with an error.
      */
-    private copyMock(srce: Entry, destdir: DirectoryEntry, newName: string): Promise<Entry> {
+    private copyMock(srce: Entry, destDir: DirectoryEntry, newName: string): Promise<Entry> {
         return new Promise<Entry>((resolve, reject) => {
-            srce.copyTo(destdir, newName, (deste) => {
+            srce.copyTo(destDir, newName, (deste) => {
                 resolve(deste);
             }, (err) => {
                 this.fillErrorMessageMock(err);
@@ -165,7 +170,10 @@ export class FileMock extends File {
     }
 
     /**
-     * @hidden
+     * Create a file writer for a certain file.
+     *
+     * @param {FileEntry} fe File entry object.
+     * @returns {Promise<FileWriter>} Promise resolved with the FileWriter.
      */
     private createWriterMock(fe: FileEntry): Promise<FileWriter> {
         return new Promise<FileWriter>((resolve, reject) => {
@@ -179,7 +187,9 @@ export class FileMock extends File {
     }
 
     /**
-     * @hidden
+     * Fill the message for an error.
+     *
+     * @param {any} err Error.
      */
     private fillErrorMessageMock(err: any): void {
         try {
@@ -350,11 +360,16 @@ export class FileMock extends File {
     }
 
     /**
-     * @hidden
+     * Move a file or directory.
+     *
+     * @param {Entry} srce The Entry to copy.
+     * @param {DirectoryEntry} destDir The directory where to move the file/dir.
+     * @param {string} newName New name of the file/dir.
+     * @returns {Promise<Entry>} Returns a Promise that resolves to the new Entry object or rejects with an error.
      */
-    private moveMock(srce: Entry, destdir: DirectoryEntry, newName: string): Promise<Entry> {
+    private moveMock(srce: Entry, destDir: DirectoryEntry, newName: string): Promise<Entry> {
         return new Promise<Entry>((resolve, reject) => {
-            srce.moveTo(destdir, newName, (deste) => {
+            srce.moveTo(destDir, newName, (deste) => {
                 resolve(deste);
             }, (err) => {
                 this.fillErrorMessageMock(err);
@@ -448,7 +463,10 @@ export class FileMock extends File {
     }
 
     /**
-     * @hidden
+     * Read all the files and directories inside a directory.
+     *
+     * @param {DirectoryReader} dr The directory reader.
+     * @return {Promise<Entry[]>} Promise resolved with the list of files/dirs.
      */
     private readEntriesMock(dr: DirectoryReader): Promise<Entry[]> {
         return new Promise<Entry[]>((resolve, reject) => {
@@ -485,7 +503,7 @@ export class FileMock extends File {
                     }
                 };
 
-                fileEntry.file(file => {
+                fileEntry.file((file) => {
                     reader[`readAs${readAs}`].call(reader, file);
                 }, error => {
                     reject(error);
@@ -495,7 +513,10 @@ export class FileMock extends File {
     }
 
     /**
-     * @hidden
+     * Delete a file.
+     *
+     * @param {Entry} fe The file to remove.
+     * @return {Promise<any>} Promise resolved when done.
      */
     private removeMock(fe: Entry): Promise<any> {
         return new Promise<any>((resolve, reject) => {
@@ -592,7 +613,10 @@ export class FileMock extends File {
     }
 
     /**
-     * @hidden
+     * Remove a directory and all its contents.
+     *
+     * @param {DirectoryEntry} de Directory to remove.
+     * @return {Promise<any>} Promise resolved when done.
      */
     private rimrafMock(de: DirectoryEntry): Promise<any> {
         return new Promise<any>((resolve, reject) => {
@@ -606,11 +630,15 @@ export class FileMock extends File {
     }
 
     /**
-     * @hidden
+     * Write some data in a file.
+     *
+     * @param {FileWriter} writer File writer.
+     * @param {any} data The data to write.
+     * @return {Promise<any>} Promise resolved when done.
      */
-    private writeMock(writer: FileWriter, gu: any): Promise<any> {
+    private writeMock(writer: FileWriter, data: any): Promise<any> {
-        if (gu instanceof Blob) {
+        if (data instanceof Blob) {
-            return this.writeFileInChunksMock(writer, gu);
+            return this.writeFileInChunksMock(writer, data);
         }
 
         return new Promise<any>((resolve, reject) => {
@@ -621,7 +649,7 @@ export class FileMock extends File {
                     resolve(evt);
                 }
             };
-            writer.write(gu);
+            writer.write(data);
         });
     }
 
@@ -661,7 +689,6 @@ export class FileMock extends File {
     /**
      * Write content to FileEntry.
      *
-     * @hidden
      * @param {FileEntry} fe File entry object.
      * @param {string | Blob} text Content or blob to write.
      * @param {IWriteOptions} options replace file if set to true. See WriteOptions for more information.
@@ -682,15 +709,19 @@ export class FileMock extends File {
     }
 
     /**
-    * @hidden
+     * Write a file in chunks.
-    */
+     *
-    private writeFileInChunksMock(writer: FileWriter, file: Blob) {
+     * @param {FileWriter} writer File writer.
+     * @param {Blob} data Data to write.
+     * @return {Promise<any>} Promise resolved when done.
+     */
+    private writeFileInChunksMock(writer: FileWriter, data: Blob) : Promise<any> {
         const BLOCK_SIZE = 1024 * 1024;
         let writtenSize = 0;
 
         function writeNextChunk() {
-            const size = Math.min(BLOCK_SIZE, file.size - writtenSize);
+            const size = Math.min(BLOCK_SIZE, data.size - writtenSize);
-            const chunk = file.slice(writtenSize, writtenSize + size);
+            const chunk = data.slice(writtenSize, writtenSize + size);
 
             writtenSize += size;
             writer.write(chunk);
@@ -699,7 +730,7 @@ export class FileMock extends File {
         return new Promise<any>((resolve, reject) => {
             writer.onerror = reject;
             writer.onwrite = () => {
-                if (writtenSize < file.size) {
+                if (writtenSize < data.size) {
                     writeNextChunk();
                 } else {
                     resolve();

src/core/login/providers/helper.ts

@@ -39,7 +39,7 @@ export interface CoreLoginSSOData {
 };
 
 /**
- * Emulates the Cordova Zip plugin in desktop apps and in browser.
+ * Helper provider that provides some common features regarding authentication.
  */
 @Injectable()
 export class CoreLoginHelperProvider {

src/manifest.json

@@ -1,13 +0,0 @@
-{
-  "name": "Moodle Mobile",
-  "short_name": "Moodle Mobile",
-  "start_url": "index.html",
-  "display": "standalone",
-  "icons": [{
-    "src": "assets/imgs/logo.png",
-    "sizes": "512x512",
-    "type": "image/png"
-  }],
-  "background_color": "#4e8ef7",
-  "theme_color": "#4e8ef7"
-}

src/service-worker.js

@@ -1,31 +0,0 @@
-/**
- * Check out https://googlechromelabs.github.io/sw-toolbox/ for
- * more info on how to use sw-toolbox to custom configure your service worker.
- */
-
-
-'use strict';
-importScripts('./build/sw-toolbox.js');
-
-self.toolbox.options.cache = {
-  name: 'ionic-cache'
-};
-
-// pre-cache our key assets
-self.toolbox.precache(
-  [
-    './build/main.js',
-    './build/vendor.js',
-    './build/main.css',
-    './build/polyfills.js',
-    'index.html',
-    'manifest.json'
-  ]
-);
-
-// dynamically cache any other local assets
-self.toolbox.router.any('/*', self.toolbox.fastest);
-
-// for any other requests go to the network, cache,
-// and then only use that cached resource if your user goes offline
-self.toolbox.router.default = self.toolbox.networkFirst;