From 2bcf3e2e14f033a6dde7cf63a3302cecb3ee7236 Mon Sep 17 00:00:00 2001 From: Dani Palou Date: Tue, 16 Jun 2020 14:18:20 +0200 Subject: [PATCH] MOBILE-3401 android: Revert Android changes for webview plugin --- src/components/iframe/iframe.ts | 3 +-- src/providers/file.ts | 8 +++----- src/providers/utils/url.ts | 3 +-- src/providers/ws.ts | 2 +- 4 files changed, 6 insertions(+), 10 deletions(-) diff --git a/src/components/iframe/iframe.ts b/src/components/iframe/iframe.ts index dff2fd024..84560094c 100644 --- a/src/components/iframe/iframe.ts +++ b/src/components/iframe/iframe.ts @@ -25,7 +25,6 @@ import { CoreIframeUtilsProvider } from '@providers/utils/iframe'; import { CoreUtilsProvider } from '@providers/utils/utils'; import { CoreSplitViewComponent } from '@components/split-view/split-view'; import { CoreUrl } from '@singletons/url'; -import { WKWebViewCookiesWindow } from 'cordova-plugin-wkwebview-cookies'; @Component({ selector: 'core-iframe', @@ -102,7 +101,7 @@ export class CoreIframeComponent implements OnInit, OnChanges { if (this.platform.is('ios') && !this.urlUtils.isLocalFileUrl(url)) { // Save a "fake" cookie for the iframe's domain to fix a bug in WKWebView. try { - const win = window; + const win = window; const urlParts = CoreUrl.parse(url); await win.WKWebViewCookies.setCookie({ diff --git a/src/providers/file.ts b/src/providers/file.ts index ea33e7313..e5d30996c 100644 --- a/src/providers/file.ts +++ b/src/providers/file.ts @@ -1251,7 +1251,7 @@ export class CoreFileProvider { * @return Converted src. */ convertFileSrc(src: string): string { - return this.appProvider.isMobile() ? ( window).Ionic.WebView.convertFileSrc(src) : src; + return this.appProvider.isIOS() ? ( window).Ionic.WebView.convertFileSrc(src) : src; } /** @@ -1261,13 +1261,11 @@ export class CoreFileProvider { * @return Unconverted src. */ unconvertFileSrc(src: string): string { - if (!this.appProvider.isMobile()) { + if (!this.appProvider.isIOS()) { return src; } - const scheme = this.platform.is('ios') ? CoreConfigConstants.ioswebviewscheme : 'http'; - - return src.replace(scheme + '://localhost/_app_file_', 'file://'); + return src.replace(CoreConfigConstants.ioswebviewscheme + '://localhost/_app_file_', 'file://'); } } diff --git a/src/providers/utils/url.ts b/src/providers/utils/url.ts index a335d082e..1d3877eb9 100644 --- a/src/providers/utils/url.ts +++ b/src/providers/utils/url.ts @@ -453,8 +453,7 @@ export class CoreUrlUtilsProvider { return scheme == 'cdvfile' || scheme == 'file' || scheme == 'filesystem' || - scheme == CoreConfigConstants.ioswebviewscheme || - (scheme == 'http' && domain == 'localhost'); + scheme == CoreConfigConstants.ioswebviewscheme; } /** diff --git a/src/providers/ws.ts b/src/providers/ws.ts index 6220a9de5..97f8ee323 100644 --- a/src/providers/ws.ts +++ b/src/providers/ws.ts @@ -978,7 +978,7 @@ export class CoreWSProvider { options.responseType = options.responseType || 'json'; options.timeout = typeof options.timeout == 'undefined' ? this.getRequestTimeout() : options.timeout; - if (this.appProvider.isMobile()) { + if (this.appProvider.isIOS()) { // Use the cordova plugin. if (url.indexOf('file://') === 0) { // We cannot load local files using the http native plugin. Use file provider instead.