From 07e5d2bbf20760a1d86484693753edf2f65b2289 Mon Sep 17 00:00:00 2001
From: Dani Palou <dani@moodle.com>
Date: Mon, 9 Nov 2020 08:50:24 +0100
Subject: [PATCH] MOBILE-3585 lint: Fix some lint errors and warnings

---
 .../emulator/components/capture-media/capture-media.html  | 2 +-
 src/app/core/emulator/services/capture.helper.ts          | 1 -
 src/app/core/login/pages/reconnect/reconnect.html         | 8 ++++++--
 src/app/core/mainmenu/pages/menu/menu.html                | 6 ++++--
 src/app/core/settings/settings-init.module.ts             | 4 +---
 src/app/services/utils/dom.ts                             | 2 +-
 6 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/src/app/core/emulator/components/capture-media/capture-media.html b/src/app/core/emulator/components/capture-media/capture-media.html
index b2afae1dd..fcd74424e 100644
--- a/src/app/core/emulator/components/capture-media/capture-media.html
+++ b/src/app/core/emulator/components/capture-media/capture-media.html
@@ -1,6 +1,6 @@
 <ion-header>
     <ion-toolbar>
-        <ion-title>{{ title | translate }}</ion-title>
+        <ion-title *ngIf="title">{{ title | translate }}</ion-title>
 
         <ion-buttons slot="end">
             <ion-button (click)="cancel()">{{ 'core.cancel' | translate }}</ion-button>
diff --git a/src/app/core/emulator/services/capture.helper.ts b/src/app/core/emulator/services/capture.helper.ts
index a8589a625..9df20ccaa 100644
--- a/src/app/core/emulator/services/capture.helper.ts
+++ b/src/app/core/emulator/services/capture.helper.ts
@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-import { CoreCanceledError } from '@/app/classes/errors/cancelederror';
 import { Injectable } from '@angular/core';
 import { CameraOptions } from '@ionic-native/camera/ngx';
 import { CaptureAudioOptions, CaptureImageOptions, CaptureVideoOptions, MediaFile } from '@ionic-native/media-capture/ngx';
diff --git a/src/app/core/login/pages/reconnect/reconnect.html b/src/app/core/login/pages/reconnect/reconnect.html
index f11aeb816..c1d18e233 100644
--- a/src/app/core/login/pages/reconnect/reconnect.html
+++ b/src/app/core/login/pages/reconnect/reconnect.html
@@ -49,10 +49,14 @@
         <ion-grid class="ion-padding">
             <ion-row>
                 <ion-col>
-                    <ion-button expand="block" color="light" (click)="cancel($event)">{{ 'core.login.cancel' | translate }}</ion-button>
+                    <ion-button expand="block" color="light" (click)="cancel($event)">
+                        {{ 'core.login.cancel' | translate }}
+                    </ion-button>
                 </ion-col>
                 <ion-col>
-                    <ion-button type="submit" expand="block" [disabled]="!credForm.valid">{{ 'core.login.loginbutton' | translate }}</ion-button>
+                    <ion-button type="submit" expand="block" [disabled]="!credForm.valid">
+                        {{ 'core.login.loginbutton' | translate }}
+                    </ion-button>
                 </ion-col>
             </ion-row>
         </ion-grid>
diff --git a/src/app/core/mainmenu/pages/menu/menu.html b/src/app/core/mainmenu/pages/menu/menu.html
index caa058462..65c5db9b6 100644
--- a/src/app/core/mainmenu/pages/menu/menu.html
+++ b/src/app/core/mainmenu/pages/menu/menu.html
@@ -2,9 +2,11 @@
     <ion-tab-bar slot="bottom" [hidden]="hidden">
         <ion-spinner *ngIf="!loaded"></ion-spinner>
 
-        <ion-tab-button tab="redirect" [disabled]="true" [hidden]="true"></ion-tab-button> <!-- [root]="redirectPage" [rootParams]="redirectParams" -->
+        <ion-tab-button tab="redirect" [disabled]="true" [hidden]="true"></ion-tab-button>
+        <!-- @todo: [root]="redirectPage" [rootParams]="redirectParams" -->
 
-        <ion-tab-button (ionTabButtonClick)="tabClicked($event, tab.page)" [hidden]="!loaded && tab.hide" *ngFor="let tab of tabs" [tab]="tab.page" [disabled]="tab.hide" layout="label-hide"  class="{{tab.class}}">
+        <ion-tab-button (ionTabButtonClick)="tabClicked($event, tab.page)" [hidden]="!loaded && tab.hide" *ngFor="let tab of tabs"
+            [tab]="tab.page" [disabled]="tab.hide" layout="label-hide"  class="{{tab.class}}">
             <ion-icon [name]="tab.icon"></ion-icon>
             <ion-label>{{ tab.title | translate }}</ion-label>
             <ion-badge *ngIf="tab.badge">{{ tab.badge }}</ion-badge>
diff --git a/src/app/core/settings/settings-init.module.ts b/src/app/core/settings/settings-init.module.ts
index 70c559c98..10b819776 100644
--- a/src/app/core/settings/settings-init.module.ts
+++ b/src/app/core/settings/settings-init.module.ts
@@ -16,7 +16,6 @@ import { NgModule } from '@angular/core';
 import { Routes } from '@angular/router';
 
 import { CoreMainMenuRoutingModule } from '@core/mainmenu/mainmenu-routing.module';
-import { CoreSettingsHelperProvider } from './services/settings.helper';
 
 const routes: Routes = [
     {
@@ -37,12 +36,11 @@ const routes: Routes = [
         CoreMainMenuRoutingModule,
     ],
     providers: [
-        CoreSettingsHelperProvider,
     ],
 })
 export class CoreSettingsInitModule {
 
-    constructor(settingsHelper: CoreSettingsHelperProvider) {
+    constructor() {
         // @todo
         // settingsHelper.initDomSettings();
     }
diff --git a/src/app/services/utils/dom.ts b/src/app/services/utils/dom.ts
index a7fb099bd..ec31a81bc 100644
--- a/src/app/services/utils/dom.ts
+++ b/src/app/services/utils/dom.ts
@@ -1537,7 +1537,7 @@ export class CoreDomUtilsProvider {
      * @return Promise resolved when modal presented.
      */
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    showTextareaPrompt(title: string, message: string, buttons: (string | any)[], placeholder?: string): Promise<any> {
+    showTextareaPrompt(title: string, message: string, buttons: (string | unknown)[], placeholder?: string): Promise<unknown> {
         // @todo
         return Promise.resolve();
     }