CIT/Vmeda.Online
3
0
Fork 1
forked from EVOgeek/Vmeda.Online
Code Pull Requests Activity

MOBILE-3947 notifications: Fix unreactive aria-label

Browse Source
This commit is contained in:
Pau Ferrer Ocaña 2024-01-10 14:13:37 +01:00
parent a90d4bda34
commit cf8f8ee0ee
2 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/addons/notifications/pages/list/list.html
View File

@ -19,11 +19,8 @@
<core-loading [hideUntil]="notifications.loaded"> <core-loading [hideUntil]="notifications.loaded">
<ion-item *ngFor="let notification of notifications.items" class="ion-text-wrap" <ion-item *ngFor="let notification of notifications.items" class="ion-text-wrap"
[attr.aria-current]="notifications.getItemAriaCurrent(notification)" [attr.aria-label]=" [attr.aria-current]="notifications.getItemAriaCurrent(notification)" (click)="notifications.select(notification)" button
notification.timeread [detail]="false" lines="full">
? notification.subject
: 'addon.notifications.unreadnotification' | translate: {$a: notification.subject}"
(click)="notifications.select(notification)" button [detail]="false" lines="full">
<core-user-avatar *ngIf="notification.useridfrom > 0" [user]="notification" slot="start" <core-user-avatar *ngIf="notification.useridfrom > 0" [user]="notification" slot="start"
[profileUrl]="notification.profileimageurlfrom" [fullname]="notification.userfromfullname" [profileUrl]="notification.profileimageurlfrom" [fullname]="notification.userfromfullname"
@ -43,7 +40,10 @@
</ng-container> </ng-container>
<ion-label> <ion-label>
<p class="item-heading"> <p class="item-heading" [attr.aria-label]="
notification.timeread
? notification.subject
: 'addon.notifications.unreadnotification' | translate: {$a: notification.subject}">
<core-format-text [text]="notification.subject" contextLevel="system" [contextInstanceId]="0" <core-format-text [text]="notification.subject" contextLevel="system" [contextInstanceId]="0"
[wsNotFiltered]="true" /> [wsNotFiltered]="true" />
</p> </p>

1
src/addons/notifications/tests/behat/notifications.feature
View File

@ -78,7 +78,6 @@ Feature: Notifications
Then I should find "Test 10 description" in the app Then I should find "Test 10 description" in the app
But I should not find "Test 09 description" in the app But I should not find "Test 09 description" in the app
@ionic7_failure
Scenario: Tablet navigation Scenario: Tablet navigation
Given I entered the app as "student1" Given I entered the app as "student1"
And I change viewport size to "1200x640" in the app And I change viewport size to "1200x640" in the app