CIT/Vmeda.Online
3
0
Fork 1
forked from EVOgeek/Vmeda.Online
Code Pull Requests Activity

MOBILE-4081 addons: Delete manager instances

Browse Source 
This prevents errors for trying to get the source of a destroyed manager (for example, for subsequent asynchronous calls fetching data).
This commit is contained in:
Noel De Martin 2022-11-24 12:38:38 +01:00
parent 61f8d8c242
commit c94785a94f
3 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/addons/calendar/components/calendar/calendar.ts
View File

@ -340,7 +340,9 @@ export class AddonCalendarCalendarComponent implements OnInit, DoCheck, OnDestro
ngOnDestroy(): void {
this.undeleteEventObserver?.off();
this.manager?.destroy();
this.managerUnsubscribe && this.managerUnsubscribe();
this.managerUnsubscribe?.();
delete this.manager;
}
}

4
src/addons/calendar/pages/day/day.page.ts
View File

@ -457,7 +457,9 @@ export class AddonCalendarDayPage implements OnInit, OnDestroy {
this.filterChangedObserver?.off();
this.manager?.getSource().forgetRelatedSources();
this.manager?.destroy();
this.managerUnsubscribe && this.managerUnsubscribe();
this.managerUnsubscribe?.();
delete this.manager;
}
}

4
src/addons/mod/book/pages/contents/contents.ts
View File

@ -314,8 +314,10 @@ export class AddonModBookContentsPage implements OnInit, OnDestroy {
* @inheritdoc
*/
ngOnDestroy(): void {
this.managerUnsubscribe && this.managerUnsubscribe();
this.manager?.destroy();
this.managerUnsubscribe?.();
delete this.manager;
}
}