From c4748c5238027f8b8219b386c2f315c2e4372715 Mon Sep 17 00:00:00 2001
From: Dani Palou <dani@moodle.com>
Date: Thu, 20 Jun 2024 16:53:34 +0200
Subject: [PATCH] MOBILE-4612 core: Remove deprecated values yes/no for auto
 login

---
 .../badges/pages/issued-badge/issued-badge.html    | 14 +++++++-------
 src/addons/calendar/pages/event/event.html         |  2 +-
 src/core/components/sites-list/sites-list.html     |  2 +-
 .../login/pages/email-signup/email-signup.html     |  2 +-
 .../mainmenu/components/user-menu/user-menu.html   |  4 ++--
 src/core/features/settings/pages/about/about.html  |  8 ++++----
 .../settings/pages/deviceinfo/deviceinfo.html      |  4 ++--
 .../features/settings/pages/licenses/licenses.html | 12 ++++++------
 src/core/features/user/pages/about/about.html      |  6 +++---
 src/core/features/viewer/pages/iframe/iframe.ts    |  5 +----
 10 files changed, 28 insertions(+), 31 deletions(-)

diff --git a/src/addons/badges/pages/issued-badge/issued-badge.html b/src/addons/badges/pages/issued-badge/issued-badge.html
index 5f06dc1d6..9686be66d 100644
--- a/src/addons/badges/pages/issued-badge/issued-badge.html
+++ b/src/addons/badges/pages/issued-badge/issued-badge.html
@@ -49,7 +49,7 @@
                 <ion-item class="ion-text-wrap" *ngIf="badge.issuercontact">
                     <ion-label>
                         <p class="item-heading">{{ 'addon.badges.contact' | translate}}</p>
-                        <p><a href="mailto:{{badge.issuercontact}}" core-link auto-login="no" [showBrowserWarning]="false">
+                        <p><a href="mailto:{{badge.issuercontact}}" core-link [autoLogin]="false" [showBrowserWarning]="false">
                                 {{ badge.issuercontact }}
                             </a></p>
                     </ion-label>
@@ -95,7 +95,7 @@
                 <ion-item class="ion-text-wrap" *ngIf="badge.imageauthoremail">
                     <ion-label>
                         <p class="item-heading">{{ 'addon.badges.imageauthoremail' | translate}}</p>
-                        <p><a href="mailto:{{badge.imageauthoremail}}" core-link auto-login="no" [showBrowserWarning]="false">
+                        <p><a href="mailto:{{badge.imageauthoremail}}" core-link [autoLogin]="false" [showBrowserWarning]="false">
                                 {{ badge.imageauthoremail }}
                             </a></p>
                     </ion-label>
@@ -103,7 +103,7 @@
                 <ion-item class="ion-text-wrap" *ngIf="badge.imageauthorurl">
                     <ion-label>
                         <p class="item-heading">{{ 'addon.badges.imageauthorurl' | translate}}</p>
-                        <p><a [href]="badge.imageauthorurl" core-link auto-login="no"> {{ badge.imageauthorurl }} </a></p>
+                        <p><a [href]="badge.imageauthorurl" core-link [autoLogin]="false"> {{ badge.imageauthorurl }} </a></p>
                     </ion-label>
                 </ion-item>
                 <ion-item class="ion-text-wrap" *ngIf="badge.imagecaption">
@@ -166,7 +166,7 @@
                     <ion-label>
                         <p class="item-heading">{{ 'addon.badges.issueremail' | translate}}</p>
                         <p>
-                            <a href="mailto:{{badge.endorsement.issueremail}}" core-link auto-login="no" [showBrowserWarning]="false">
+                            <a href="mailto:{{badge.endorsement.issueremail}}" core-link [autoLogin]="false" [showBrowserWarning]="false">
                                 {{ badge.endorsement.issueremail }}
                             </a>
                         </p>
@@ -175,7 +175,7 @@
                 <ion-item class="ion-text-wrap" *ngIf="badge.endorsement.issuerurl">
                     <ion-label>
                         <p class="item-heading">{{ 'addon.badges.issuerurl' | translate}}</p>
-                        <p><a [href]="badge.endorsement.issuerurl" core-link auto-login="no"> {{ badge.endorsement.issuerurl }} </a></p>
+                        <p><a [href]="badge.endorsement.issuerurl" core-link [autoLogin]="false"> {{ badge.endorsement.issuerurl }} </a></p>
                     </ion-label>
                 </ion-item>
                 <ion-item class="ion-text-wrap" *ngIf="badge.endorsement.dateissued">
@@ -187,7 +187,7 @@
                 <ion-item class="ion-text-wrap" *ngIf="badge.endorsement.claimid">
                     <ion-label>
                         <p class="item-heading">{{ 'addon.badges.claimid' | translate}}</p>
-                        <p><a [href]="badge.endorsement.claimid" core-link auto-login="no"> {{ badge.endorsement.claimid }} </a></p>
+                        <p><a [href]="badge.endorsement.claimid" core-link [autoLogin]="false"> {{ badge.endorsement.claimid }} </a></p>
                     </ion-label>
                 </ion-item>
                 <ion-item class="ion-text-wrap" *ngIf="badge.endorsement.claimcomment">
@@ -225,7 +225,7 @@
                     </ion-label>
                 </ion-item-divider>
                 <ion-item class="ion-text-wrap" *ngFor="let alignment of badge.alignment" [href]="alignment.targeturl" core-link
-                    auto-login="no">
+                    [autoLogin]="false">
                     <ion-label>
                         <p class="item-heading">{{ alignment.targetname }}</p>
                     </ion-label>
diff --git a/src/addons/calendar/pages/event/event.html b/src/addons/calendar/pages/event/event.html
index 6f21e79ef..b7f1ff8e4 100644
--- a/src/addons/calendar/pages/event/event.html
+++ b/src/addons/calendar/pages/event/event.html
@@ -104,7 +104,7 @@
                 <ion-label>
                     <p class="item-heading">{{ 'core.location' | translate}}</p>
                     <p>
-                        <a [href]="event.encodedLocation" core-link auto-login="no">
+                        <a [href]="event.encodedLocation" core-link [autoLogin]="false">
                             <core-format-text [text]="event.location" [contextLevel]="event.contextLevel"
                                 [contextInstanceId]="event.contextInstanceId" />
                         </a>
diff --git a/src/core/components/sites-list/sites-list.html b/src/core/components/sites-list/sites-list.html
index 429820659..890c48764 100644
--- a/src/core/components/sites-list/sites-list.html
+++ b/src/core/components/sites-list/sites-list.html
@@ -27,7 +27,7 @@
                 <core-format-text [text]="site.siteName" clean="true" [siteId]="site.id" />
             </h2>
             <p *ngIf="displaySiteUrl(site)">
-                <a [href]="site.siteUrl" core-link [autoLogin]="isCurrentSite ? 'yes' : 'no'">
+                <a [href]="site.siteUrl" core-link [autoLogin]="!!isCurrentSite">
                     {{ site.siteUrlWithoutProtocol }}
                 </a>
             </p>
diff --git a/src/core/features/login/pages/email-signup/email-signup.html b/src/core/features/login/pages/email-signup/email-signup.html
index 51c27f859..ff8eb087e 100644
--- a/src/core/features/login/pages/email-signup/email-signup.html
+++ b/src/core/features/login/pages/email-signup/email-signup.html
@@ -27,7 +27,7 @@
                         {{ 'core.login.signuprequiredfieldnotsupported' | translate }}
                     </ion-label>
                 </ion-item>
-                <ion-button expand="block" [href]="signupUrl" core-link autoLogin="no" [showBrowserWarning]="false">
+                <ion-button expand="block" [href]="signupUrl" core-link [autoLogin]="false" [showBrowserWarning]="false">
                     {{ 'core.openinbrowser' | translate }}
                 </ion-button>
             </ion-list>
diff --git a/src/core/features/mainmenu/components/user-menu/user-menu.html b/src/core/features/mainmenu/components/user-menu/user-menu.html
index 6dc40ca15..7063eba8e 100644
--- a/src/core/features/mainmenu/components/user-menu/user-menu.html
+++ b/src/core/features/mainmenu/components/user-menu/user-menu.html
@@ -17,7 +17,7 @@
         <ion-list>
             <!-- Site info with URL and clickable. -->
             <ion-item button class="core-usermenu-siteinfo ion-text-wrap" *ngIf="siteInfo && displaySiteUrl" lines="full" [detail]="false"
-                [href]="siteUrl" core-link auto-login="yes">
+                [href]="siteUrl" core-link>
                 <ion-label>
                     <!-- Show site logo. -->
                     <img class="core-usermenu-site-logo" *ngIf="siteLogo && siteLogoLoaded" [src]="siteLogo" role="presentation" alt=""
@@ -25,7 +25,7 @@
                     <p class="core-usermenu-sitename">
                         <core-format-text [text]="siteName" contextLevel="system" [contextInstanceId]="0" [wsNotFiltered]="true" />
                     </p>
-                    <a [href]="siteUrl" core-link auto-login="yes" class="core-usermenu-siteurl">{{ siteUrl }}</a>
+                    <a [href]="siteUrl" core-link class="core-usermenu-siteurl">{{ siteUrl }}</a>
                 </ion-label>
             </ion-item>
             <!-- Site info without URL and not clickable. -->
diff --git a/src/core/features/settings/pages/about/about.html b/src/core/features/settings/pages/about/about.html
index ce17902b3..83002f367 100644
--- a/src/core/features/settings/pages/about/about.html
+++ b/src/core/features/settings/pages/about/about.html
@@ -17,12 +17,12 @@
             <ion-icon name="far-copyright" slot="start" aria-hidden="true" />
             <ion-label>{{ 'core.settings.opensourcelicenses' | translate }}</ion-label>
         </ion-item>
-        <ion-item *ngIf="privacyPolicy" class="ion-text-wrap" button core-link auto-login="no" [href]="privacyPolicy" [detail]="true"
+        <ion-item *ngIf="privacyPolicy" class="ion-text-wrap" button core-link [autoLogin]="false" [href]="privacyPolicy" [detail]="true"
             detailIcon="open-outline">
             <ion-icon name="fas-user-shield" slot="start" aria-hidden="true" />
             <ion-label>{{ 'core.settings.privacypolicy' | translate }}</ion-label>
         </ion-item>
-        <ion-item *ngIf="a11yStatement" class="ion-text-wrap" button core-link auto-login="no" [href]="a11yStatement" [detail]="true"
+        <ion-item *ngIf="a11yStatement" class="ion-text-wrap" button core-link [autoLogin]="false" [href]="a11yStatement" [detail]="true"
             detailIcon="open-outline">
             <ion-icon name="fas-universal-access" slot="start" aria-hidden="true" />
             <ion-label>{{ 'core.settings.accessstatement' | translate }}</ion-label>
@@ -32,8 +32,8 @@
             <ion-icon name="fas-bullhorn" slot="start" aria-hidden="true" />
             <ion-label>{{ 'core.settings.helpusimprove' | translate }}</ion-label>
         </ion-item>
-        <ion-item *ngIf="legalDisclaimer" class="ion-text-wrap" button core-link auto-login="no" [href]="legalDisclaimer" [detail]="true"
-            detailIcon="open-outline">
+        <ion-item *ngIf="legalDisclaimer" class="ion-text-wrap" button core-link [autoLogin]="false" [href]="legalDisclaimer"
+            [detail]="true" detailIcon="open-outline">
             <ion-icon name="fas-scale-balanced" slot="start" aria-hidden="true" />
             <ion-label>{{ 'core.settings.legaldisclaimer' | translate }}</ion-label>
         </ion-item>
diff --git a/src/core/features/settings/pages/deviceinfo/deviceinfo.html b/src/core/features/settings/pages/deviceinfo/deviceinfo.html
index 08886bdc5..1eedc62d5 100644
--- a/src/core/features/settings/pages/deviceinfo/deviceinfo.html
+++ b/src/core/features/settings/pages/deviceinfo/deviceinfo.html
@@ -42,7 +42,7 @@
                 <p class="item-heading">{{ 'core.settings.siteinfo' | translate }}<ng-container *ngIf="deviceInfo.isPrefixedUrl">
                         *</ng-container>
                 </p>
-                <p *ngIf="displaySiteUrl"><a [href]="deviceInfo.siteUrl" core-link auto-login="yes">{{ deviceInfo.siteUrl }}</a></p>
+                <p *ngIf="displaySiteUrl"><a [href]="deviceInfo.siteUrl" core-link>{{ deviceInfo.siteUrl }}</a></p>
                 <p *ngIf="deviceInfo.siteVersion">{{ deviceInfo.siteVersion }}</p>
                 <p *ngIf="deviceInfo.siteId">{{ deviceInfo.siteId }}</p>
             </ion-label>
@@ -51,7 +51,7 @@
             <ion-label class="ion-text-wrap">
                 <p class="item-heading">{{ 'core.settings.filesystemroot' | translate }}</p>
                 <p>
-                    <a *ngIf="fsClickable" [href]="deviceInfo.fileSystemRoot" core-link auto-login="no">
+                    <a *ngIf="fsClickable" [href]="deviceInfo.fileSystemRoot" core-link [autoLogin]="false">
                         {{ deviceInfo.fileSystemRoot }}
                     </a>
                 </p>
diff --git a/src/core/features/settings/pages/licenses/licenses.html b/src/core/features/settings/pages/licenses/licenses.html
index 7710faa0f..eacf71709 100644
--- a/src/core/features/settings/pages/licenses/licenses.html
+++ b/src/core/features/settings/pages/licenses/licenses.html
@@ -14,30 +14,30 @@
         <ion-searchbar [(ngModel)]="textFilter" (ionInput)="filterChanged($event.target)" (ionCancel)="filterChanged($event.target)"
             [placeholder]="'core.filter' | translate" class="ion-margin-vertical" />
         <ion-list>
-            <ion-item button *ngIf="error" class="ion-text-wrap" [href]="licensesUrl" core-link auto-login="no" [detail]="false">
+            <ion-item button *ngIf="error" class="ion-text-wrap" [href]="licensesUrl" core-link [autoLogin]="false" [detail]="false">
                 <ion-label>
                     {{ 'core.settings.opensourcelicenses' | translate }}
                 </ion-label>
-                <ion-button [href]="licensesUrl" target="_blank" fill="clear" slot="end" core-link auto-login="no">
+                <ion-button [href]="licensesUrl" target="_blank" fill="clear" slot="end" core-link [autoLogin]="false">
                     {{ 'core.view' | translate }}</ion-button>
             </ion-item>
             <ng-container *ngIf="!error">
                 <ion-item *ngFor="let license of licenses" class="ion-text-wrap" lines="inset">
                     <ion-label>
                         <p class="item-heading">
-                            <a *ngIf="license.repository" [href]="license.repository" core-link auto-login="no">{{ license.name }}</a>
+                            <a *ngIf="license.repository" [href]="license.repository" core-link [autoLogin]="false">{{ license.name }}</a>
                             <ng-container *ngIf="!license.repository">{{ license.name }}</ng-container> - {{ license.version }}
                         </p>
                         <p *ngIf="license.publisher">
                             {{ 'core.settings.publisher' | translate }}{{ 'core.labelsep' | translate }} {{ license.publisher }}
                         </p>
                         <p>{{ 'core.settings.license' | translate }}{{ 'core.labelsep' | translate }} {{ license.licenses }}</p>
-                        <p><a *ngIf="license.url" [href]="license.url" core-link auto-login="no">{{ license.url }}</a></p>
-                        <p><a *ngIf="license.email" [href]="'mailto:' + license.email" core-link auto-login="no"
+                        <p><a *ngIf="license.url" [href]="license.url" core-link [autoLogin]="false">{{ license.url }}</a></p>
+                        <p><a *ngIf="license.email" [href]="'mailto:' + license.email" core-link [autoLogin]="false"
                                 [showBrowserWarning]="false">{{ license.email }}</a></p>
                     </ion-label>
                     <ion-button *ngIf="license.licenseUrl" [href]="license.licenseUrl" target="_blank" fill="clear" slot="end" core-link
-                        auto-login="no" [ariaLabel]="'core.view' | translate">
+                        [autoLogin]="false" [ariaLabel]="'core.view' | translate">
                         <ion-icon slot="icon-only" name="fas-up-right-from-square" aria-hidden="true" />
                     </ion-button>
                 </ion-item>
diff --git a/src/core/features/user/pages/about/about.html b/src/core/features/user/pages/about/about.html
index f068fdc3e..7d7d43007 100644
--- a/src/core/features/user/pages/about/about.html
+++ b/src/core/features/user/pages/about/about.html
@@ -44,7 +44,7 @@
                 <ion-item class="ion-text-wrap" *ngIf="user.email">
                     <ion-label>
                         <p class="item-heading">{{ 'core.user.email' | translate }}</p>
-                        <p><a class="core-anchor" href="mailto:{{user.email}}" core-link auto-login="no" [showBrowserWarning]="false">
+                        <p><a class="core-anchor" href="mailto:{{user.email}}" core-link [autoLogin]="false" [showBrowserWarning]="false">
                                 {{ user.email }}
                             </a></p>
                     </ion-label>
@@ -70,7 +70,7 @@
                 <ion-item class="ion-text-wrap" *ngIf="user.phone1">
                     <ion-label>
                         <p class="item-heading">{{ 'core.user.phone1' | translate}}</p>
-                        <p><a class="core-anchor" href="tel:{{user.phone1}}" core-link auto-login="no" [showBrowserWarning]="false">
+                        <p><a class="core-anchor" href="tel:{{user.phone1}}" core-link [autoLogin]="false" [showBrowserWarning]="false">
                                 {{ user.phone1 }}
                             </a></p>
                     </ion-label>
@@ -78,7 +78,7 @@
                 <ion-item class="ion-text-wrap" *ngIf="user.phone2">
                     <ion-label>
                         <p class="item-heading">{{ 'core.user.phone2' | translate}}</p>
-                        <p><a class="core-anchor" href="tel:{{user.phone2}}" core-link auto-login="no" [showBrowserWarning]="false">
+                        <p><a class="core-anchor" href="tel:{{user.phone2}}" core-link [autoLogin]="false" [showBrowserWarning]="false">
                                 {{ user.phone2 }}
                             </a></p>
                     </ion-label>
diff --git a/src/core/features/viewer/pages/iframe/iframe.ts b/src/core/features/viewer/pages/iframe/iframe.ts
index 5b6ef0d13..ed468be0b 100644
--- a/src/core/features/viewer/pages/iframe/iframe.ts
+++ b/src/core/features/viewer/pages/iframe/iframe.ts
@@ -31,10 +31,7 @@ export class CoreViewerIframePage implements OnInit {
     async ngOnInit(): Promise<void> {
         this.title = CoreNavigator.getRouteParam('title');
         this.url = CoreNavigator.getRouteParam('url');
-        const autoLoginParam = CoreNavigator.getRouteParam('autoLogin') ?? true;
-        this.autoLogin = typeof autoLoginParam === 'boolean' ?
-            autoLoginParam :
-            autoLoginParam !== 'no'; // Support deprecated values yes/no/check.
+        this.autoLogin = CoreNavigator.getRouteBooleanParam('autoLogin') ?? true;
     }
 
 }