CIT/Vmeda.Online
3
0
Fork 1
forked from EVOgeek/Vmeda.Online
Code Pull Requests Activity

MOBILE-4085 course-format: Improve performance with OnPush

Browse Source
This commit is contained in:
Alfonso Salces 2022-05-31 15:08:12 +02:00
parent 7fd6a4bd22
commit bc7704a1af
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/core/features/course/components/course-format/course-format.ts
View File

@ -23,6 +23,8 @@ import {
QueryList, QueryList,
Type, Type,
ElementRef, ElementRef,
ChangeDetectionStrategy,
ChangeDetectorRef,
} from '@angular/core'; } from '@angular/core';
import { CoreDomUtils } from '@services/utils/dom'; import { CoreDomUtils } from '@services/utils/dom';
import { CoreDynamicComponent } from '@components/dynamic-component/dynamic-component'; import { CoreDynamicComponent } from '@components/dynamic-component/dynamic-component';
@ -64,6 +66,7 @@ import { CoreUserTourDirectiveOptions } from '@directives/user-tour';
selector: 'core-course-format', selector: 'core-course-format',
templateUrl: 'course-format.html', templateUrl: 'course-format.html',
styleUrls: ['course-format.scss'], styleUrls: ['course-format.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
}) })
export class CoreCourseFormatComponent implements OnInit, OnChanges, OnDestroy { export class CoreCourseFormatComponent implements OnInit, OnChanges, OnDestroy {
@ -120,6 +123,7 @@ export class CoreCourseFormatComponent implements OnInit, OnChanges, OnDestroy {
constructor( constructor(
protected content: IonContent, protected content: IonContent,
protected elementRef: ElementRef, protected elementRef: ElementRef,
protected changeDetectorRef: ChangeDetectorRef,
) { ) {
// Pass this instance to all components so they can use its methods and properties. // Pass this instance to all components so they can use its methods and properties.
this.data.coreCourseFormatComponent = this; this.data.coreCourseFormatComponent = this;
@ -173,6 +177,7 @@ export class CoreCourseFormatComponent implements OnInit, OnChanges, OnDestroy {
} }
} }
} }
this.changeDetectorRef.markForCheck();
}); });
} }
@ -195,6 +200,7 @@ export class CoreCourseFormatComponent implements OnInit, OnChanges, OnDestroy {
if (changes.sections && this.sections) { if (changes.sections && this.sections) {
this.treatSections(this.sections); this.treatSections(this.sections);
} }
this.changeDetectorRef.markForCheck();
} }
/** /**
@ -229,6 +235,7 @@ export class CoreCourseFormatComponent implements OnInit, OnChanges, OnDestroy {
this.loadSingleSectionComponent(), this.loadSingleSectionComponent(),
this.loadAllSectionsComponent(), this.loadAllSectionsComponent(),
]); ]);
this.changeDetectorRef.markForCheck();
} }
/** /**
@ -523,6 +530,7 @@ export class CoreCourseFormatComponent implements OnInit, OnChanges, OnDestroy {
CoreCourse.logView(this.course.id, newSection.section, undefined, this.course.fullname), CoreCourse.logView(this.course.id, newSection.section, undefined, this.course.fullname),
); );
} }
this.changeDetectorRef.markForCheck();
} }
/** /**