From a6e68c71760f49f81bd0d783437d7a68c4a71c8d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pau=20Ferrer=20Oca=C3=B1a?= Date: Mon, 16 Dec 2019 17:20:48 +0100 Subject: [PATCH] MOBILE-3213 survey: Check question is required to disable the submission --- src/addon/mod/survey/components/index/index.ts | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/addon/mod/survey/components/index/index.ts b/src/addon/mod/survey/components/index/index.ts index dfa6696c3..633957845 100644 --- a/src/addon/mod/survey/components/index/index.ts +++ b/src/addon/mod/survey/components/index/index.ts @@ -163,13 +163,10 @@ export class AddonModSurveyIndexComponent extends CoreCourseModuleMainActivityCo * @return If answers are valid */ isValidResponse(): boolean { - for (const x in this.answers) { - if (this.answers[x] === -1) { - return false; - } - } - - return true; + return !this.questions.some((question) => { + return question.required && question.name && + (question.type === 0 ? this.answers[question.name] == '' : parseInt(this.answers[question.name], 10) === -1); + }); } /**