From 9d87226ad85d62be414dcd117fde252aaa8ccfd9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pau=20Ferrer=20Oca=C3=B1a?= <crazyserver@gmail.com>
Date: Mon, 7 Dec 2020 16:20:24 +0100
Subject: [PATCH] MOBILE-3591 course: Fix linting

---
 src/core/components/context-menu/context-menu.ts       |  4 +++-
 .../infinite-loading/core-infinite-loading.html        |  2 +-
 .../courses/pages/course-preview/course-preview.html   | 10 +++++-----
 .../courses/pages/course-preview/course-preview.ts     |  2 +-
 src/core/features/courses/pages/search/search.html     |  2 +-
 5 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/src/core/components/context-menu/context-menu.ts b/src/core/components/context-menu/context-menu.ts
index ed46b46c2..bfcacec1f 100644
--- a/src/core/components/context-menu/context-menu.ts
+++ b/src/core/components/context-menu/context-menu.ts
@@ -37,12 +37,14 @@ export class CoreContextMenuComponent implements OnInit, OnDestroy {
 
     hideMenu = true; // It will be unhidden when items are added.
     expanded = false;
+    uniqueId: string;
+
     protected items: CoreContextMenuItemComponent[] = [];
     protected itemsMovedToParent: CoreContextMenuItemComponent[] = [];
     protected itemsChangedStream: Subject<void>; // Stream to update the hideMenu boolean when items change.
     protected instanceId: string;
     protected parentContextMenu?: CoreContextMenuComponent;
-    protected uniqueId: string;
+
 
     constructor(
         protected popoverCtrl: PopoverController,
diff --git a/src/core/components/infinite-loading/core-infinite-loading.html b/src/core/components/infinite-loading/core-infinite-loading.html
index cb99cd201..94cd3663b 100644
--- a/src/core/components/infinite-loading/core-infinite-loading.html
+++ b/src/core/components/infinite-loading/core-infinite-loading.html
@@ -9,7 +9,7 @@
     </div>
 </ng-container>
 
-<ion-infinite-scroll [disabled]="!enabled || error || loadingMore" (ionInfinite)="loadMore($event)" [position]="position">
+<ion-infinite-scroll [disabled]="!enabled || error || loadingMore" (ionInfinite)="loadMore()" [position]="position">
     <ion-infinite-scroll-content></ion-infinite-scroll-content>
 </ion-infinite-scroll>
 
diff --git a/src/core/features/courses/pages/course-preview/course-preview.html b/src/core/features/courses/pages/course-preview/course-preview.html
index 5d4e09c2b..444ad7027 100644
--- a/src/core/features/courses/pages/course-preview/course-preview.html
+++ b/src/core/features/courses/pages/course-preview/course-preview.html
@@ -16,7 +16,7 @@
                 <img [src]="courseImageUrl" core-external-content alt=""/>
             </div>
         </div>
-        <div class="core-course-thumb-parallax-content">
+        <div class="core-course-thumb-parallax-content" *ngIf="course">
             <ion-item class="ion-text-wrap" (click)="openCourse()" [title]="course.fullname" [attr.details]="!avoidOpenCourse && canAccessCourse">
                 <ion-icon name="fas-graduation-cap" fixed-width slot="start"></ion-icon>
                 <ion-label>
@@ -43,7 +43,7 @@
                         <h2>{{ 'core.teachers' | translate }}</h2>
                     </ion-label>
                 </ion-item-divider>
-                <ion-item class="ion-text-wrap" *ngFor="let contact of course.contacts" core-user-link
+                <!-- @todo <ion-item class="ion-text-wrap" *ngFor="let contact of course.contacts" core-user-link
                     [userId]="contact.id"
                     [courseId]="isEnrolled ? course.id : null"
                     [attr.aria-label]="'core.viewprofile' | translate">
@@ -55,7 +55,7 @@
                     <ion-label>
                         <h2>{{contact.fullname}}</h2>
                     </ion-label>
-                </ion-item>
+                </ion-item>-->
                 <ion-item-divider></ion-item-divider>
             </ng-container>
 
@@ -102,10 +102,10 @@
             </ion-item>
             <ion-item *ngIf="canAccessCourse && downloadCourseEnabled" (click)="prefetchCourse()" detail="false"
                     [attr.aria-label]="prefetchCourseData.statusTranslatable | translate">
-                <ion-icon *ngIf="!prefetchCourseData.status != statusDownloaded && !prefetchCourseData.loading"
+                <ion-icon *ngIf="(prefetchCourseData.status != statusDownloaded) && !prefetchCourseData.loading"
                     [name]="prefetchCourseData.icon" slot="start">
                 </ion-icon>
-                <ion-icon *ngIf="prefetchCourseData.status == statusDownloaded && !prefetchCourseData.loading"
+                <ion-icon *ngIf="(prefetchCourseData.status == statusDownloaded) && !prefetchCourseData.loading"
                     slot="start" [name]="prefetchCourseData.icon" color="success"
                     [attr.aria-label]="prefetchCourseData.statusTranslatable | translate" role="status">
                 </ion-icon>
diff --git a/src/core/features/courses/pages/course-preview/course-preview.ts b/src/core/features/courses/pages/course-preview/course-preview.ts
index f9e527be8..57da1fc46 100644
--- a/src/core/features/courses/pages/course-preview/course-preview.ts
+++ b/src/core/features/courses/pages/course-preview/course-preview.ts
@@ -64,6 +64,7 @@ export class CoreCoursesCoursePreviewPage implements OnInit, OnDestroy {
     downloadCourseEnabled: boolean;
     courseUrl = '';
     courseImageUrl?: string;
+    isMobile: boolean;
 
     protected isGuestEnabled = false;
     protected guestInstanceId?: number;
@@ -71,7 +72,6 @@ export class CoreCoursesCoursePreviewPage implements OnInit, OnDestroy {
     protected waitStart = 0;
     protected enrolUrl = '';
     protected paypalReturnUrl = '';
-    protected isMobile: boolean;
     protected pageDestroyed = false;
     protected courseStatusObserver?: CoreEventObserver;
 
diff --git a/src/core/features/courses/pages/search/search.html b/src/core/features/courses/pages/search/search.html
index a67c4bb35..9bb306c95 100644
--- a/src/core/features/courses/pages/search/search.html
+++ b/src/core/features/courses/pages/search/search.html
@@ -7,7 +7,7 @@
     </ion-toolbar>
 </ion-header>
 <ion-content>
-    <core-search-box (onSubmit)="search($event)" (onClear)="clearSearch($event)"
+    <core-search-box (onSubmit)="search($event)" (onClear)="clearSearch()"
     [placeholder]="'core.courses.search' | translate" [searchLabel]="'core.courses.search' | translate" autoFocus="true"
     searchArea="CoreCoursesSearch"></core-search-box>