diff --git a/src/addons/block/learningplans/services/block-handler.ts b/src/addons/block/learningplans/services/block-handler.ts index 774ddad1c..38afe6a04 100644 --- a/src/addons/block/learningplans/services/block-handler.ts +++ b/src/addons/block/learningplans/services/block-handler.ts @@ -34,8 +34,6 @@ export class AddonBlockLearningPlansHandlerService extends CoreBlockBaseHandler * @return Data or promise resolved with the data. */ getDisplayData(): CoreBlockHandlerData { - // @todo - return { title: 'addon.block_learningplans.pluginname', class: 'addon-block-learning-plans', diff --git a/src/addons/competency/pages/plan/plan.html b/src/addons/competency/pages/plan/plan.html index 19e76d108..d95cd3f41 100644 --- a/src/addons/competency/pages/plan/plan.html +++ b/src/addons/competency/pages/plan/plan.html @@ -65,7 +65,7 @@ -

{{ 'addon.competency.learningplancompetencies' | translate }}

+ {{ 'addon.competency.learningplancompetencies' | translate }}
diff --git a/src/addons/mod/forum/services/forum.ts b/src/addons/mod/forum/services/forum.ts index c9ee8c548..901f138ba 100644 --- a/src/addons/mod/forum/services/forum.ts +++ b/src/addons/mod/forum/services/forum.ts @@ -49,8 +49,6 @@ declare module '@singletons/events' { /** * Service that provides some features for forums. - * - * @todo Add all content. */ @Injectable({ providedIn: 'root' }) export class AddonModForumProvider { diff --git a/src/addons/mod/quiz/pages/review/review.html b/src/addons/mod/quiz/pages/review/review.html index 6ed4b8fe7..5b602f6fe 100644 --- a/src/addons/mod/quiz/pages/review/review.html +++ b/src/addons/mod/quiz/pages/review/review.html @@ -23,8 +23,8 @@ - {{ 'addon.mod_quiz.reviewofpreview' | translate }} - {{ 'addon.mod_quiz.reviewofattempt' | translate:{$a: attempt.attempt} }} + {{ 'addon.mod_quiz.reviewofpreview' | translate }} + {{ 'addon.mod_quiz.reviewofattempt' | translate:{$a: attempt.attempt} }} diff --git a/src/addons/mod/workshop/workshop-lazy.module.ts b/src/addons/mod/workshop/workshop-lazy.module.ts index 14fec0473..7199432d5 100644 --- a/src/addons/mod/workshop/workshop-lazy.module.ts +++ b/src/addons/mod/workshop/workshop-lazy.module.ts @@ -35,7 +35,7 @@ const routes: Routes = [ canDeactivate: [CanLeaveGuard], }, { - path: ':courseId/:cmId/:submissionId/edit', // @todo + path: ':courseId/:cmId/:submissionId/edit', component: AddonModWorkshopEditSubmissionPage, canDeactivate: [CanLeaveGuard], }, diff --git a/src/core/features/grades/pages/course/course.scss b/src/core/features/grades/pages/course/course.scss index 308fbe906..601e79771 100644 --- a/src/core/features/grades/pages/course/course.scss +++ b/src/core/features/grades/pages/course/course.scss @@ -1,7 +1,18 @@ @import "~theme/globals"; -// @todo darkmode -// @todo RTL layout +:host { + --header-background: var(--white); + --odd-cell-background: var(--gray-lighter); + --even-cell-background: var(--white); + --icon-color: #999999; +} + +:host-context(body.dark) { + --header-background: var(--black); + --odd-cell-background: var(--gray-darker); + --even-cell-background: var(--black); + --icon-color: #eeeeee; +} :host-context(ion-app.md) { --border-color: var(--ion-item-border-color, var(--ion-border-color, var(--ion-color-step-150, rgba(0, 0, 0, .13)))); @@ -18,16 +29,12 @@ font-size: 16px; color: var(--ion-text-color); - // @include darkmode() { - // color: $core-dark-text-color; - // } - tr { border-bottom: 1px solid var(--border-color); } th, td { - padding: 10px 0 10px 10px; + @include padding(10px, 10px, 10px, null); vertical-align: top; white-space: normal; text-align: start; @@ -36,11 +43,7 @@ thead th { vertical-align: bottom; font-weight: bold; - background-color: var(--white); - - // @include darkmode() { - // background-color: $black; - // } + background-color: var(--header-background); } tbody th { @@ -48,15 +51,15 @@ } #gradeitem { - padding-left: 5px; + @include padding(null, null, null, 5px); } .core-grades-table-gradeitem { - padding-left: 5px; + @include padding(null, null, null, 5px); font-weight: bold; &.column-itemname { - padding-left: 0; + @include padding(null, null, null, 0); } img { @@ -65,17 +68,17 @@ } ion-icon { - color: #999999; + color: var(--icon-color); } span { - margin-left: 5px; + @include margin(null, null, null, 5px); } } .core-grades-table-feedback { - padding-left: 5px; + @include padding(null, null, null, 5px); .no-overflow { overflow: auto; @@ -89,27 +92,16 @@ } .odd { - td, th, th[aria-current="page"] { - background-color: var(--gray-lighter); - - // @include darkmode() { - // background-color: $gray-darker; - // } + background-color: var(--odd-cell-background); } } .even { - td, th, th[aria-current="page"] { - background-color: var(--white); - - // @include darkmode() { - // background-color: $black; - // } + background-color: var(--even-cell-background); } - } .core-grades-grade-clickable {