From e272a3963683de7b09cd4623d2cc95108997f312 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pau=20Ferrer=20Oca=C3=B1a?= Date: Fri, 29 Mar 2019 12:06:09 +0100 Subject: [PATCH] MOBILE-2915 workshop: Fix asssessment prefetch --- .../workshop/providers/prefetch-handler.ts | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/addon/mod/workshop/providers/prefetch-handler.ts b/src/addon/mod/workshop/providers/prefetch-handler.ts index d7e213044..ccdb6c4d2 100644 --- a/src/addon/mod/workshop/providers/prefetch-handler.ts +++ b/src/addon/mod/workshop/providers/prefetch-handler.ts @@ -332,17 +332,14 @@ export class AddonModWorkshopPrefetchHandler extends CoreCourseActivityPrefetchH }); } - if (assessments.length > 0) { - reportPromise = reportPromise.finally(() => { - const promises3 = []; - assessments.forEach((assessment, id) => { - promises3.push(this.workshopProvider.getAssessmentForm(workshop.id, id, undefined, undefined, - undefined, siteId)); - }); - - return Promise.all(promises3); - }); - } + reportPromise = reportPromise.finally(() => { + if (assessments.length > 0) { + return Promise.all(assessments.map((assessment, id) => { + return this.workshopProvider.getAssessmentForm(workshop.id, id, undefined, undefined, undefined, + siteId); + })); + } + }); promises2.push(reportPromise); if (workshop.phase == AddonModWorkshopProvider.PHASE_CLOSED) {