From 18a611ad82ec1ed6acdb4898c49ed4cdd28cfa02 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pau=20Ferrer=20Oca=C3=B1a?= <crazyserver@gmail.com>
Date: Fri, 7 Dec 2018 14:55:24 +0100
Subject: [PATCH] MOBILE-2784 feedback: Fix analysis summary access checks

---
 .../feedback/components/index/addon-mod-feedback-index.html | 6 +++---
 src/addon/mod/feedback/components/index/index.ts            | 3 ++-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/addon/mod/feedback/components/index/addon-mod-feedback-index.html b/src/addon/mod/feedback/components/index/addon-mod-feedback-index.html
index 152bc23c8..ac5eacd51 100644
--- a/src/addon/mod/feedback/components/index/addon-mod-feedback-index.html
+++ b/src/addon/mod/feedback/components/index/addon-mod-feedback-index.html
@@ -43,7 +43,7 @@
 
 
 <ng-template #basicInfo>
-    <ion-list *ngIf="(access.canedititems || access.canviewreports) && !access.isempty">
+    <ion-list *ngIf="access.canviewanalysis && !access.isempty">
         <ion-item text-wrap *ngIf="access.canedititems && (groupInfo.separateGroups || groupInfo.visibleGroups)">
             <ion-label id="addon-feedback-groupslabel" *ngIf="groupInfo.separateGroups">{{ 'core.groupsseparate' | translate }}</ion-label>
             <ion-label id="addon-feedback-groupslabel" *ngIf="groupInfo.visibleGroups">{{ 'core.groupsvisible' | translate }}</ion-label>
@@ -51,14 +51,14 @@
                 <ion-option *ngFor="let groupOpt of groupInfo.groups" [value]="groupOpt.id">{{groupOpt.name}}</ion-option>
             </ion-select>
         </ion-item>
-        <a ion-item text-wrap *ngIf="access.canviewreports || access.canedititems" (click)="access.canviewreports && openFeature('Respondents')" [attr.detail-none]="access.canviewreports ? null : true">
+        <a ion-item text-wrap (click)="access.canviewreports && feedback.completedCount > 0 && openFeature('Respondents')" [attr.detail-none]="access.canviewreports && feedback.completedCount > 0 ? null : true">
             <h2>{{ 'addon.mod_feedback.completed_feedbacks' | translate }}</h2>
             <ion-badge item-end>{{feedback.completedCount}}</ion-badge>
         </a>
         <a ion-item text-wrap *ngIf="!access.isanonymous && access.canviewreports" (click)="openFeature('NonRespondents')" detail-push>
             <h2>{{ 'addon.mod_feedback.show_nonrespondents' | translate }}</h2>
         </a>
-        <ion-item text-wrap *ngIf="access.canedititems">
+        <ion-item text-wrap>
             <h2>{{ 'addon.mod_feedback.questions' | translate }}</h2>
             <ion-badge item-end>{{feedback.itemsCount}}</ion-badge>
         </ion-item>
diff --git a/src/addon/mod/feedback/components/index/index.ts b/src/addon/mod/feedback/components/index/index.ts
index b24f1e5bb..14fbf05c3 100644
--- a/src/addon/mod/feedback/components/index/index.ts
+++ b/src/addon/mod/feedback/components/index/index.ts
@@ -212,7 +212,8 @@ export class AddonModFeedbackIndexComponent extends CoreCourseModuleMainActivity
             this.overview.timeclose = parseInt(this.feedback.timeclose) * 1000 || 0;
             this.overview.closeTimeReadable = this.overview.timeclose ?
                 moment(this.overview.timeclose).format('LLL') : '';
-
+        }
+        if (accessData.canviewanalysis) {
             // Get groups (only for teachers).
             promises.push(this.fetchGroupInfo(this.feedback.coursemodule));
         }