From 45fb4cb92a3122dc65682f9597837a0eb0f8ee51 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pau=20Ferrer=20Oca=C3=B1a?= Date: Tue, 23 Apr 2024 12:52:34 +0200 Subject: [PATCH] MOBILE-4565 a11y: Fix a lot of focus problems --- .../block/tags/components/tags/tags.scss | 3 + .../blog/pages/edit-entry/edit-entry.html | 2 +- src/addons/blog/pages/index/index.html | 54 ++++++------- src/addons/blog/pages/index/index.scss | 2 +- .../calendar/components/filter/filter.html | 2 +- .../airnotifier/pages/devices/devices.html | 3 +- .../messages/pages/settings/settings.html | 8 +- .../addon-mod-assign-submission.html | 4 +- .../mod/chat/pages/sessions/sessions.html | 2 +- .../mod/data/components/search/search.html | 2 +- .../pages/new-discussion/new-discussion.html | 6 +- src/addons/mod/glossary/pages/edit/edit.html | 6 +- .../workshop/pages/submission/submission.html | 2 +- .../pages/settings/settings.html | 6 +- src/core/components/combobox/combobox.scss | 51 +++++++----- .../core-context-menu-popover.html | 6 +- src/core/components/mod-icon/mod-icon.ts | 2 +- .../components/swipe-slides/swipe-slides.html | 3 +- .../tabs-outlet/core-tabs-outlet.html | 4 +- src/core/components/tabs/tabs.scss | 2 + src/core/features/courses/pages/my/my.scss | 1 - .../features/mainmenu/pages/menu/menu.scss | 79 ++++++++++--------- src/core/features/settings/pages/dev/dev.html | 8 +- .../settings/pages/deviceinfo/deviceinfo.html | 2 +- .../settings/pages/general/general.html | 38 ++++----- .../features/settings/pages/site/site.html | 2 +- .../synchronization/synchronization.html | 2 +- src/core/services/utils/dom.ts | 34 +++++--- src/theme/components/collapsible-header.scss | 11 +++ src/theme/components/error-accordion.scss | 12 +-- src/theme/components/ion-card.scss | 2 + src/theme/components/ion-item.scss | 16 +++- src/theme/components/ion-tab-bar.scss | 6 -- src/theme/helpers/custom.mixins.scss | 60 ++++++++++++-- src/theme/theme.base.scss | 67 ++-------------- src/theme/theme.design-system.scss | 3 + src/theme/theme.scss | 1 - 37 files changed, 277 insertions(+), 237 deletions(-) delete mode 100644 src/theme/components/ion-tab-bar.scss diff --git a/src/addons/block/tags/components/tags/tags.scss b/src/addons/block/tags/components/tags/tags.scss index 2282396da..2de71afde 100644 --- a/src/addons/block/tags/components/tags/tags.scss +++ b/src/addons/block/tags/components/tags/tags.scss @@ -1,3 +1,5 @@ +@use "theme/globals" as *; + :host .core-block-content ::ng-deep { ion-label { max-width: 100%; @@ -31,6 +33,7 @@ vertical-align: baseline; text-decoration: none; border-radius: var(--mdl-shape-borderRadius-xs); + @include core-focus-outline(); } .s20 { font-size: 2.7em; diff --git a/src/addons/blog/pages/edit-entry/edit-entry.html b/src/addons/blog/pages/edit-entry/edit-entry.html index 842cf3400..2c516a75a 100644 --- a/src/addons/blog/pages/edit-entry/edit-entry.html +++ b/src/addons/blog/pages/edit-entry/edit-entry.html @@ -54,7 +54,7 @@
@if (associationsExpanded) { - + @if (associatedModule) { @if (showMyEntriesToggle) { - + {{ 'addon.blog.showonlyyourentries' | translate }} @@ -65,34 +65,32 @@
- -
-
- -
- - @if (tagsEnabled && entry.tags && entry.tags!.length > 0) { - - -
{{ 'core.tag.tags' | translate }}:
- -
-
- } - - @for (file of entry.attachmentfiles; track $index) { - - } - - @if (entry.uniquehash) { - - {{ 'addon.blog.linktooriginalentry' | translate }} - - } - +
+
+
- + + @if (tagsEnabled && entry.tags && entry.tags!.length > 0) { + + +
{{ 'core.tag.tags' | translate }}:
+ +
+
+ } + + @for (file of entry.attachmentfiles; track $index) { + + } + + @if (entry.uniquehash) { + + {{ 'addon.blog.linktooriginalentry' | translate }} + + } + +
@if (entry.lastmodified > entry.created || (entry.userid === currentUserId && entry.publishstate !== 'draft')) { diff --git a/src/addons/blog/pages/index/index.scss b/src/addons/blog/pages/index/index.scss index 16cd7210f..c610046a4 100644 --- a/src/addons/blog/pages/index/index.scss +++ b/src/addons/blog/pages/index/index.scss @@ -7,7 +7,7 @@ } .entry { - border-top: 1px solid var(--stroke); + border-bottom: 1px solid var(--stroke); &-visibility-permission { display: flex; diff --git a/src/addons/calendar/components/filter/filter.html b/src/addons/calendar/components/filter/filter.html index 5d746163a..ba83242d3 100644 --- a/src/addons/calendar/components/filter/filter.html +++ b/src/addons/calendar/components/filter/filter.html @@ -9,7 +9,7 @@ - +