CIT/Vmeda.Online
3
0
Fork 1
forked from EVOgeek/Vmeda.Online
Code Pull Requests Activity

Merge pull request #3709 from alfonso-salces/MOBILE-4360

Browse Source 
MOBILE-4360 lang: Trim custom string values
This commit is contained in:
Dani Palou 2023-06-22 17:44:05 +02:00 committed by GitHub
commit 21ff63e413
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/services/lang.ts
View File

@ -380,7 +380,7 @@ export class CoreLangProvider {
const list: string[] = strings.split(/(?:\r\n|\r|\n)/); const list: string[] = strings.split(/(?:\r\n|\r|\n)/);
list.forEach((entry: string) => { list.forEach((entry: string) => {
const values: string[] = entry.split('|'); const values: string[] = entry.split('|').map(value => value.trim());
if (values.length < 3) { if (values.length < 3) {
// Not enough data, ignore the entry. // Not enough data, ignore the entry.

19
src/tests/behat/customlangstrings.feature Normal file
View File

@ -0,0 +1,19 @@
@app @javascript
Feature: Custom lang strings
Background:
Given the following "users" exist:
| username |
| student1 |
Scenario: Customlangstrings without whitespaces
Given the following config values are set as admin:
| customlangstrings | core.courses.mycourses\|Foo\|en | tool_mobile |
When I entered the app as "student1"
Then I should be able to press "Foo" in the app
Scenario: Customlangstrings with whitespaces
Given the following config values are set as admin:
| customlangstrings | core.courses.mycourses\| Foo with whitespaces \|en | tool_mobile |
When I entered the app as "student1"
Then I should be able to press "Foo with whitespaces" in the app