MOBILE-3371 search: Remove search results count

Given some issues with the LMS webservices (they return inconsistent totalcount depending on the page), we've decided to remove this information from the UI to avoid confusion.

scripts/langindex.json

@@ -685,7 +685,6 @@
   "addon.mod_forum.removefromfavourites": "forum",
   "addon.mod_forum.reply": "forum",
   "addon.mod_forum.replyplaceholder": "forum",
-  "addon.mod_forum.searchresults": "course",
   "addon.mod_forum.subject": "forum",
   "addon.mod_forum.tagarea_forum_posts": "forum",
   "addon.mod_forum.thisforumhasduedate": "forum",

src/addons/mod/forum/lang.json

@@ -59,7 +59,6 @@
     "removefromfavourites": "Unstar this discussion",
     "reply": "Reply",
     "replyplaceholder": "Write your reply...",
-    "searchresults": "Search results: {{$a}}",
     "subject": "Subject",
     "tagarea_forum_posts": "Forum posts",
     "thisforumhasduedate": "The due date for posting to this forum is {{$a}}.",

src/addons/mod/forum/pages/search/search.html

@@ -23,10 +23,6 @@
         <core-search-box (onSubmit)="search($event)" (onClear)="clearSearch()" [placeholder]="'core.search' | translate"
             [searchLabel]="'core.search' | translate" [autoFocus]="true" [searchArea]="searchAreaId"></core-search-box>
 
-        <div *ngIf="!resultsSource.isEmpty()" class="results-count">
-            {{ 'addon.mod_forum.searchresults' | translate: { $a: resultsSource.getTotalResults() } }}
-        </div>
-
         <ion-list *ngIf="resultsSource.isLoaded()">
             <core-search-global-search-result *ngFor="let result of resultsSource.getItems()" [result]="result" [showCourse]="false"
                 (onClick)="visitResult(result)">

src/addons/mod/forum/tests/behat/search.feature

@@ -46,6 +46,5 @@ Feature: Test Forum Search
 
     When I set the field "Search" to "message" in the app
     And I press "Search" "button" in the app
-    Then I should find "Search results: 2" in the app
-    And I should find "Test forum 1" in the app
+    Then I should find "Test forum 1" in the app
     And I should find "Test forum 2" in the app