From 02c2a5e508d915deae6813d58fe26eba92dae328 Mon Sep 17 00:00:00 2001 From: Noel De Martin Date: Thu, 17 Mar 2022 15:40:14 +0100 Subject: [PATCH] MOBILE-3833 feedback: Fix attempts pagination --- .../mod/feedback/classes/feedback-attempts-source.ts | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/addons/mod/feedback/classes/feedback-attempts-source.ts b/src/addons/mod/feedback/classes/feedback-attempts-source.ts index 4ef92a857..62410098d 100644 --- a/src/addons/mod/feedback/classes/feedback-attempts-source.ts +++ b/src/addons/mod/feedback/classes/feedback-attempts-source.ts @@ -135,8 +135,14 @@ export class AddonModFeedbackAttemptsSource extends CoreRoutedItemsManagerSource const totalItemsLoaded = this.getPageLength() * (page + 1); const pageAttempts: AddonModFeedbackAttemptItem[] = [ - ...result.attempts, - ...result.anonattempts, + // The page argument is ignored in the webservice when there is only one page, + // so we should ignore the responses of pages beyond the first if that's the case. + ...(page === 0 || result.totalattempts > AddonModFeedbackProvider.PER_PAGE) + ? result.attempts + : [], + ...(page === 0 || result.totalanonattempts > AddonModFeedbackProvider.PER_PAGE) + ? result.anonattempts + : [], ]; return {